Support stack traces even when "debug" is off

gbrail · gbrail · commit b29d63ad24bb · 2021-06-01T13:38:02.000-07:00
When the generated bytecode has no debug symbols, it still has
line numbers. Generate a stack trace that replaces the
missing file name with "unknown." This at least means that there
are line numbers and sometimes function names.
diff --git a/src/org/mozilla/javascript/RhinoException.java b/src/org/mozilla/javascript/RhinoException.java
@@ -275,8 +275,7 @@ public ScriptStackElement[] getScriptStack(int limit, String hideFunction) {
             String fileName = e.getFileName();
             if (e.getMethodName().startsWith("_c_")
                     && e.getLineNumber() > -1
-                    && fileName != null
-                    && !fileName.endsWith(".java")) {
+                    && (fileName == null || !fileName.endsWith(".java"))) {
                 String methodName = e.getMethodName();
                 Matcher match = JAVA_STACK_PATTERN.matcher(methodName);
                 // the method representing the main script is always "_c_script_0" -
@@ -287,6 +286,9 @@ public ScriptStackElement[] getScriptStack(int limit, String hideFunction) {
                 if (!printStarted && hideFunction.equals(methodName)) {
                     printStarted = true;
                 } else if (printStarted && ((limit < 0) || (count < limit))) {
+                    if (fileName == null) {
+                        fileName = "unknown";
+                    }
                     list.add(new ScriptStackElement(fileName, methodName, e.getLineNumber()));
                     count++;
                 }
