buffer: refactor to use primordials instead of Array#reduce

aduh95 · danbev · commit ff048bd79771 · 2020-12-07T06:08:44.000+01:00
PR-URL: nodejs/node#36392 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -24,6 +24,7 @@
 const {
   Array,
   ArrayIsArray,
+  ArrayPrototypeForEach,
   Error,
   MathFloor,
   MathMin,
@@ -825,11 +826,12 @@ Buffer.prototype[customInspectSymbol] = function inspect(recurseTimes, ctx) {
   if (ctx) {
     let extras = false;
     const filter = ctx.showHidden ? ALL_PROPERTIES : ONLY_ENUMERABLE;
-    const obj = getOwnNonIndexProperties(this, filter).reduce((obj, key) => {
-      extras = true;
-      obj[key] = this[key];
-      return obj;
-    }, ObjectCreate(null));
+    const obj = ObjectCreate(null);
+    ArrayPrototypeForEach(getOwnNonIndexProperties(this, filter),
+                          (key) => {
+                            extras = true;
+                            obj[key] = this[key];
+                          });
     if (extras) {
       if (this.length !== 0)
         str += ', ';
