Fix http.ClientRequest crashes if end() was called twice

koichik · koichik · commit bffb758243ca · 2011-07-30T00:47:54.000+09:00
Fixes #1417.
Fixes #1223.
diff --git a/lib/http2.js b/lib/http2.js
@@ -648,6 +648,9 @@ OutgoingMessage.prototype.addTrailers = function(headers) {
 
 
 OutgoingMessage.prototype.end = function(data, encoding) {
+  if (this.finished) {
+    return false;
+  }
   if (!this._header) {
     this._implicitHeader();
   }

Original file line number	Diff line number	Diff line change
`@@ -648,6 +648,9 @@ OutgoingMessage.prototype.addTrailers = function(headers) {`
`648`	`648`
`649`	`649`
`650`	`650`	`OutgoingMessage.prototype.end = function(data, encoding) {`
	`651`	`+ if (this.finished) {`
	`652`	`+ return false;`
	`653`	`+ }`
`651`	`654`	`if (!this._header) {`
`652`	`655`	`this._implicitHeader();`
`653`	`656`	`}`