Make border for Comment to look exactly like borders around other text fields

vlsi · vlsi · commit 9497afa46288 · 2019-10-01T23:21:27.000+03:00
JTextArea does not have border by default (see https://bugs.openjdk.java.net/browse/JDK-4139076) It is probably intended to be wrapped into JScrollPane or something like that. However JMeter does not want to put scrolling there for now, so we want the border.
diff --git a/src/core/src/main/java/org/apache/jmeter/gui/CommentPanel.java b/src/core/src/main/java/org/apache/jmeter/gui/CommentPanel.java
@@ -20,10 +20,11 @@
 
 import java.awt.BorderLayout;
 
-import javax.swing.BorderFactory;
 import javax.swing.JLabel;
 import javax.swing.JPanel;
 import javax.swing.JTextArea;
+import javax.swing.JTextField;
+import javax.swing.border.Border;
 
 import org.apache.jmeter.util.JMeterUtils;
 
@@ -52,7 +53,10 @@ private void init() { // WARNING: called from ctor so must not be overridden (i.
         commentField = new JTextArea();
         JLabel commentLabel = new JLabel(JMeterUtils.getResString("testplan_comments")); //$NON-NLS-1$
         commentLabel.setLabelFor(commentField);
-        commentField.setBorder(BorderFactory.createEtchedBorder());
+        // JTextArea does not have border by default (see https://bugs.openjdk.java.net/browse/JDK-4139076)
+        // However we want it to look like a text field. So we borrow a border from there
+        Border border = new JTextField().getBorder();
+        commentField.setBorder(border);
         commentLabel.setVerticalAlignment(JLabel.TOP);
         add(commentLabel, BorderLayout.WEST);
         add(commentField, BorderLayout.CENTER);
