Disable slow and regular asserts in Android dev builds

willholen · facebook-github-bot · commit f72b68787dba · 2019-09-04T12:49:12.000-07:00
Summary:
We were building Android OSS dev builds with HERMES_SLOW_DEBUG and
without NDEBUG. This causes them to be significantly slower than
necessary.

Reviewed By: avp

Differential Revision: D17186406

fbshipit-source-id: ecc0b670f8dc43e270a60c139b5eed44ae9915dd
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -130,7 +130,7 @@ if (HERMES_IS_ANDROID)
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-command-line-argument")
 
   # JS developers aren't VM developers. Give them a faster build.
-  set(CMAKE_CXX_FLAGS_DEBUG "-O3 -g")
+  set(CMAKE_CXX_FLAGS_DEBUG "-O3 -g -DNDEBUG")
 
   # The release build can focus on size.
   set(CMAKE_CXX_FLAGS_RELEASE "-Os -DNDEBUG")
diff --git a/android/hermes/build.gradle b/android/hermes/build.gradle
@@ -29,6 +29,7 @@ android {
         arguments "-DLLVM_BUILD_BASE=${hermes_ws}/llvm"
         arguments "-DLLVM_SRC_DIR=${hermes_ws}/llvm"
         arguments "-DFBSOURCE_DIR=${fbsource}"
+        arguments "-DHERMES_SLOW_DEBUG=False"
         targets "libhermes"
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ android {`
`29`	`29`	`arguments "-DLLVM_BUILD_BASE=${hermes_ws}/llvm"`
`30`	`30`	`arguments "-DLLVM_SRC_DIR=${hermes_ws}/llvm"`
`31`	`31`	`arguments "-DFBSOURCE_DIR=${fbsource}"`
	`32`	`+ arguments "-DHERMES_SLOW_DEBUG=False"`
`32`	`33`	`targets "libhermes"`
`33`	`34`	`}`
`34`	`35`	`}`