Skip to content

Commit cf303af

Browse files
Michał Gregorczykfacebook-github-bot
authored andcommitted
remove dependency on fbsource//xplat/perf/instrumentation/sampled:sampled
Summary: This data is not reported anymore. Reviewed By: dulinriley Differential Revision: D18904902 fbshipit-source-id: 4a6f018722fbf9c0ac290b4504dc14b69b5de8c6
1 parent 5316c86 commit cf303af

2 files changed

Lines changed: 0 additions & 54 deletions

File tree

API/hermes/hermes.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
#include "hermes/BCGen/HBC/BytecodeDataProvider.h"
2222
#include "hermes/BCGen/HBC/BytecodeProviderFromSrc.h"
2323
#include "hermes/DebuggerAPI.h"
24-
#include "hermes/Instrumentation/PerfMarkers.h"
2524
#include "hermes/Platform/Logging.h"
2625
#include "hermes/Public/RuntimeConfig.h"
2726
#include "hermes/Support/Algorithms.h"
@@ -1248,7 +1247,6 @@ jsi::Value HermesRuntimeImpl::evaluatePreparedJavaScript(
12481247
assert(
12491248
dynamic_cast<const HermesPreparedJavaScript *>(js.get()) &&
12501249
"js must be an instance of HermesPreparedJavaScript");
1251-
::hermes::instrumentation::HighFreqPerfMarker m("jsi-hermes-evaluate");
12521250
auto &stats = runtime_.getRuntimeStats();
12531251
const vm::instrumentation::RAIITimer timer{
12541252
"Evaluate JS", stats, stats.evaluateJS};
@@ -1498,7 +1496,6 @@ jsi::Value HermesRuntimeImpl::getProperty(
14981496
const jsi::Object &obj,
14991497
const jsi::String &name) {
15001498
return maybeRethrow([&] {
1501-
::hermes::instrumentation::PerfMarker m("jsi-hermes-getProperty-string");
15021499
vm::GCScope gcScope(&runtime_);
15031500
auto h = handle(obj);
15041501
auto res = h->getComputed_RJS(h, &runtime_, stringHandle(name));
@@ -1511,8 +1508,6 @@ jsi::Value HermesRuntimeImpl::getProperty(
15111508
const jsi::Object &obj,
15121509
const jsi::PropNameID &name) {
15131510
return maybeRethrow([&] {
1514-
::hermes::instrumentation::LowFreqPerfMarker m(
1515-
"jsi-hermes-getProperty-nameid");
15161511
vm::GCScope gcScope(&runtime_);
15171512
auto h = handle(obj);
15181513
vm::SymbolID nameID = phv(name).getSymbol();
@@ -1761,7 +1756,6 @@ jsi::Value HermesRuntimeImpl::call(
17611756
const jsi::Value *args,
17621757
size_t count) {
17631758
return maybeRethrow([&] {
1764-
::hermes::instrumentation::PerfMarker m("jsi-hermes-call");
17651759
vm::GCScope gcScope(&runtime_);
17661760
vm::Handle<vm::Callable> handle =
17671761
vm::Handle<vm::Callable>::vmcast(&phv(func));
@@ -1799,7 +1793,6 @@ jsi::Value HermesRuntimeImpl::callAsConstructor(
17991793
const jsi::Value *args,
18001794
size_t count) {
18011795
return maybeRethrow([&] {
1802-
::hermes::instrumentation::PerfMarker m("jsi-hermes-callAsConstructor");
18031796
vm::GCScope gcScope(&runtime_);
18041797
vm::Handle<vm::Callable> funcHandle =
18051798
vm::Handle<vm::Callable>::vmcast(&phv(func));

include/hermes/Instrumentation/PerfMarkers.h

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)