Prevent internal header dependencies from sneaking into external JSI headers

mhorowitz · facebook-github-bot · commit cdc4ea7dafbf · 2020-05-01T01:47:35.000-07:00
Summary:
hermes/hermes.h should not depend on VM internals.  Remove
GCExecTrace.h, and replace it with a forward declaration.

To prevent this from happening in the future, refactor the
hermes_api_library macro to remove include:include from exported_deps.

Reviewed By: dulinriley

Differential Revision: D21308540

fbshipit-source-id: 4685c247518162e9108f259d808a8b2c4f0b2044
diff --git a/API/hermes/hermes.h b/API/hermes/hermes.h
@@ -14,7 +14,6 @@
 #include <string>
 
 #include <hermes/Public/RuntimeConfig.h>
-#include <hermes/VM/GCExecTrace.h>
 #include <jsi/jsi.h>
 
 struct HermesTestHelper;
@@ -25,6 +24,7 @@ class raw_ostream;
 
 namespace hermes {
 namespace vm {
+class GCExecTrace;
 struct MockedEnvironment;
 } // namespace vm
 } // namespace hermes
