Fix domain tracking

neildhar · facebook-github-bot · commit 998c62000fb2 · 2021-01-28T16:57:07.000-08:00
Summary:
We cannot assume that the pointers in `domains_` are in sorted order,
since they may be updated by the GC. Use a linear search instead.

Reviewed By: dulinriley

Differential Revision: D26111515

fbshipit-source-id: 3b473ef5eb7776bd637ce14c92f1cc2d1d6b2f4d
diff --git a/lib/VM/Profiler/SamplingProfilerPosix.cpp b/lib/VM/Profiler/SamplingProfilerPosix.cpp
@@ -60,9 +60,9 @@ void SamplingProfiler::GlobalProfiler::unregisterRuntime(
 
 void SamplingProfiler::registerDomain(Domain *domain) {
   // If domain is not already registered, add it to the list.
-  auto it = std::lower_bound(domains_.begin(), domains_.end(), domain);
-  if (it == domains_.end() || *it != domain)
-    domains_.insert(it, domain);
+  auto it = std::find(domains_.begin(), domains_.end(), domain);
+  if (it == domains_.end())
+    domains_.push_back(domain);
 }
 
 void SamplingProfiler::markRoots(RootAcceptor &acceptor) {
