Encode userLocale before opening auth webpage

yukuku · web-flow · commit d5a4e1e5c511 · 2017-06-07T22:25:24.000+08:00
Sometimes Locale#toString() returns a string that has a '#' character. Without URL-encoding it, the string will act as page hash when the auth URL is opened in the user's web browser. As reported in issue dropbox#115
diff --git a/src/main/java/com/dropbox/core/DbxRequestUtil.java b/src/main/java/com/dropbox/core/DbxRequestUtil.java
@@ -75,7 +75,7 @@ private static String encodeUrlParams(/*@Nullable*/String userLocale,
         StringBuilder buf = new StringBuilder();
         String sep = "";
         if (userLocale != null) {
-            buf.append("locale=").append(userLocale);
+            buf.append("locale=").append(encodeUrlParam(userLocale));
             sep = "&";
         }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ private static String encodeUrlParams(/@Nullable/String userLocale,`
`75`	`75`	`StringBuilder buf = new StringBuilder();`
`76`	`76`	`String sep = "";`
`77`	`77`	`if (userLocale != null) {`
`78`		`- buf.append("locale=").append(userLocale);`
	`78`	`+ buf.append("locale=").append(encodeUrlParam(userLocale));`
`79`	`79`	`sep = "&";`
`80`	`80`	`}`
`81`	`81`