OkHttpRequestor: Deprecate getClient().

Kannan Goundan · Kannan Goundan · commit ceec021f017e · 2016-10-05T16:08:31.000-07:00
It seems like an unnecessary API.  If you want access to that client,
just keep it around instead of keeping around the HttpRequestor wrapper.
diff --git a/src/main/java/com/dropbox/core/http/OkHttp3Requestor.java b/src/main/java/com/dropbox/core/http/OkHttp3Requestor.java
@@ -82,13 +82,10 @@ public OkHttp3Requestor(OkHttpClient client) {
     }
 
     /**
-     * Returns the underlying {@code OkHttpClient} used to make requests.
-     *
-     * If you want to modify the client for a particular request, create a new instance of this
-     * requestor with the modified client.
-     *
-     * @return underlying {@code OkHttpClient} used by this requestor.
+     * @deprecated If you need access to the {@link OkHttpClient} instance you passed
+     *     into the constructor, keep track of it yourself.
      */
+    @Deprecated
     public OkHttpClient getClient() {
         return client;
     }
diff --git a/src/main/java/com/dropbox/core/http/OkHttpRequestor.java b/src/main/java/com/dropbox/core/http/OkHttpRequestor.java
@@ -85,13 +85,10 @@ public OkHttpRequestor(OkHttpClient client) {
     }
 
     /**
-     * Returns a clone of the underlying {@code OkHttpClient} used to make requests.
-     *
-     * If you want to modify the client for a particular request, create a new instance of this
-     * requestor with the modified client.
-     *
-     * @return clone of the underlying {@code OkHttpClient} used by this requestor.
+     * @deprecated If you need access to the {@link OkHttpClient} instance you passed
+     *     into the constructor, keep track of it yourself.
      */
+    @Deprecated
     public OkHttpClient getClient() {
         return client;
     }
