Skip to content

Commit 127dfca

Browse files
author
Josh Zana
committed
Fix android example to compile
Summary: - Some recent generator changes broke the Android example - Fix them Test Plan: Ran babel codegen and compiled android in Android studio Reviewers: krieb Reviewed By: krieb Differential Revision: https://tails.corp.dropbox.com/D167708
1 parent 01e3e36 commit 127dfca

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

examples/android/src/main/java/com/dropbox/core/examples/android/FileThumbnailRequestHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ public Result load(Request request, int networkPolicy) throws IOException {
4747
try {
4848
DbxDownloader<DbxFiles.FileMetadata> downloader =
4949
mFilesClient.getThumbnailBuilder(request.uri.getPath())
50-
.format(DbxFiles.ThumbnailFormat.jpeg)
51-
.size(DbxFiles.ThumbnailSize.w1024h768)
50+
.format(DbxFiles.ThumbnailFormat.jpeg())
51+
.size(DbxFiles.ThumbnailSize.w1024h768())
5252
.start();
5353

5454
return new Result(downloader.body, Picasso.LoadedFrom.NETWORK);

examples/android/src/main/java/com/dropbox/core/examples/android/FilesAdapter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import com.dropbox.core.v2.DbxFiles;
1313
import com.squareup.picasso.Picasso;
1414

15-
import java.util.ArrayList;
1615
import java.util.List;
1716

1817
/**
@@ -23,7 +22,7 @@ public class FilesAdapter extends RecyclerView.Adapter<FilesAdapter.MetadataView
2322
private final Picasso mPicasso;
2423
private final Callback mCallback;
2524

26-
public void setFiles(ArrayList<DbxFiles.Metadata> files) {
25+
public void setFiles(List<DbxFiles.Metadata> files) {
2726
mFiles = files;
2827
notifyDataSetChanged();
2928
}

examples/android/src/main/java/com/dropbox/core/examples/android/UploadFileTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ protected DbxFiles.FileMetadata doInBackground(String... params) {
5959
try {
6060
InputStream inputStream = new FileInputStream(localFile);
6161
try {
62-
mFilesClient.uploadBuilder(remoteFolderPath + "/" + remoteFileName)
63-
.mode(DbxFiles.WriteMode.overwrite)
62+
return mFilesClient.uploadBuilder(remoteFolderPath + "/" + remoteFileName)
63+
.mode(DbxFiles.WriteMode.overwrite())
6464
.run(inputStream);
6565
} finally {
6666
inputStream.close();

0 commit comments

Comments
 (0)