Merge pull request hugapi#311 from timothycrosley/feature/fix-middleware-method-binding

timothycrosley · timothycrosley · commit cf75a3e74eb2 · 2016-05-18T09:47:15.000-07:00
Feature/fix middleware method binding
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ Changelog
 =========
 ### 2.1.2
 - Fixed an issue with sharing exception handlers accross multiple modules (Thanks @soloman1124)
+- Fixed how single direction (response / request) middlewares are bounded to work when code is Cython compiled
 
 ### 2.1.1
 - Hot-fix release to ensure input formats don't die with unexpected parameters
diff --git a/hug/decorators.py b/hug/decorators.py
@@ -90,8 +90,14 @@ def request_middleware(api=None):
     """Registers a middleware function that will be called on every request"""
     def decorator(middleware_method):
         apply_to_api = hug.API(api) if api else hug.api.from_object(middleware_method)
-        middleware_method.__self__ = middleware_method
-        apply_to_api.http.add_middleware(namedtuple('MiddlewareRouter', ('process_request', ))(middleware_method))
+
+        class MiddlewareRouter(object):
+            __slots__ = ()
+
+            def process_request(self, request, response):
+                return middleware_method(request, response)
+
+        apply_to_api.http.add_middleware(MiddlewareRouter())
         return middleware_method
     return decorator
 
@@ -100,8 +106,14 @@ def response_middleware(api=None):
     """Registers a middleware function that will be called on every response"""
     def decorator(middleware_method):
         apply_to_api = hug.API(api) if api else hug.api.from_object(middleware_method)
-        middleware_method.__self__ = middleware_method
-        apply_to_api.http.add_middleware(namedtuple('MiddlewareRouter', ('process_response', ))(middleware_method))
+
+        class MiddlewareRouter(object):
+            __slots__ = ()
+
+            def process_response(self, request, response, resource):
+                return middleware_method(request, response, resource)
+
+        apply_to_api.http.add_middleware(MiddlewareRouter())
         return middleware_method
     return decorator
 
