fix($resource): action defaults should override resource defaults

marcenuc · IgorMinar · commit b3ed7a8a7a45 · 2011-09-27T00:52:12.000+02:00
defaults definned per action should take precedence over defaults
defined for the whole resource.

This is potentialy a BREAKING CHANGE in case someone relied on the buggy
behavior.
diff --git a/src/Resource.js b/src/Resource.js
@@ -109,7 +109,7 @@ ResourceFactory.prototype = {
         var value = this instanceof Resource ? this : (action.isArray ? [] : new Resource(data));
         self.xhr(
           action.method,
-          route.url(extend({}, action.params || {}, extractParams(data), params)),
+          route.url(extend({}, extractParams(data), action.params || {}, params)),
           data,
           function(status, response, responseHeaders) {
             if (response) {
diff --git a/test/ResourceSpec.js b/test/ResourceSpec.js
@@ -75,6 +75,15 @@ describe("resource", function() {
     nakedExpect(item).toEqual({id:'abc'});
   });
 
+  it("should build resource with action default param overriding default param", function(){
+    xhr.expectGET('/Customer/123').respond({id:'abc'});
+    var TypeItem = resource.route('/:type/:typeId', {type: 'Order'},
+                                  {get: {method: 'GET', params: {type: 'Customer'}}});
+    var item = TypeItem.get({typeId:123});
+    xhr.flush();
+    nakedExpect(item).toEqual({id:'abc'});
+  });
+
   it("should create resource", function(){
     xhr.expectPOST('/CreditCard', {name:'misko'}).respond({id:123, name:'misko'});
 
