chore(build): let our docker build run as root

alexeagle · alexeagle · commit e0310d5d78fe · 2016-04-25T10:18:03.000-07:00
diff --git a/Dockerfile b/Dockerfile
@@ -1,23 +1,19 @@
 # EXPERIMENTAL Docker support for angular2 build process.
-# Build with: docker build -t $USER/angular:$(git rev-list -n 1 HEAD) .
+# Build with: docker build -t $USER/angular2:$(git rev-list -n 1 HEAD) .
 FROM node:5.7.1
 MAINTAINER Alex Eagle
 
-# Don't run as root. bower complains, and it is less secure.
-RUN useradd -ms /bin/bash ngbuilder
+# Copy the minimal file to create a node_modules directory.
+# This takes advantage of docker's caching, so that the npm install
+# is only re-run when the npm-shrinkwrap.json was modified.
+COPY npm-shrinkwrap.json /home/
+WORKDIR /home
+RUN npm install --no-progress
 
-# Copy only the shrinkwrapped dependencies
-COPY npm-shrinkwrap.json /home/ngbuilder/
-WORKDIR /home/ngbuilder
-# This install command results in a cachable node_modules directory
-RUN npm install --silent
-
-COPY . /home/ngbuilder/
-# https://docs.docker.com/engine/reference/builder/#copy
-# All new files and directories are created with a UID and GID of 0.
-RUN chown -R ngbuilder:ngbuilder /home/ngbuilder
-USER ngbuilder
-ENV HOME /home/ngbuilder
+COPY . /home/
 
+# Allow the build to run as root. In a long-lived docker container,
+# this is a security vulnerability, but we don't have a CMD so our
+# container is not left running after the build completes.
 RUN npm run postinstall
 RUN npm run build
diff --git a/package.json b/package.json
@@ -27,7 +27,7 @@
   },
   "scripts": {
     "preinstall": "node tools/analytics/build-analytics start install npm3-install && node tools/analytics/build-analytics start install npm-preinstall && node tools/npm/check-node-modules && node tools/analytics/build-analytics success install npm-preinstall && node tools/analytics/build-analytics start install npm-install-net",
-    "postinstall": "node tools/analytics/build-analytics success install npm-install-net && node tools/analytics/build-analytics start install npm-postinstall && node tools/npm/copy-npm-shrinkwrap && node tools/chromedriverpatch.js && webdriver-manager update && bower install && gulp pubget.dart && npm run typings && node tools/analytics/build-analytics success install npm-postinstall && node tools/analytics/build-analytics success install npm3-install",
+    "postinstall": "node tools/analytics/build-analytics success install npm-install-net && node tools/analytics/build-analytics start install npm-postinstall && node tools/npm/copy-npm-shrinkwrap && node tools/chromedriverpatch.js && webdriver-manager update && bower install --allow-root && gulp pubget.dart && npm run typings && node tools/analytics/build-analytics success install npm-postinstall && node tools/analytics/build-analytics success install npm3-install",
     "build": "node --max-old-space-size=2048 ./node_modules/.bin/gulp build.js",
     "test": "gulp test.all.js && gulp test.all.dart",
     "typings": "tsd reinstall --overwrite --clean --config modules/angular2/tsd.json && tsd reinstall --overwrite --clean --config tools/tsd.json && tsd reinstall --overwrite --config modules/angular1_router/tsd.json"
