cleanup(html_parser): cleanup to fix analyzer warnings

vsavkin · Robert Messerle · commit aef35b47d6e3 · 2016-04-15T11:47:55.000-07:00
diff --git a/modules/angular2/src/compiler/html_parser.ts b/modules/angular2/src/compiler/html_parser.ts
@@ -150,7 +150,7 @@ class TreeBuilder {
       // parse everything in between { and }
       let parsedExp = new TreeBuilder(exp).build();
       if (parsedExp.errors.length > 0) {
-        this.errors = this.errors.concat(parsedExp.errors);
+        this.errors = this.errors.concat(<HtmlTreeError[]>parsedExp.errors);
         return;
       }
 
diff --git a/modules/angular2/src/compiler/legacy_template.ts b/modules/angular2/src/compiler/legacy_template.ts
@@ -88,7 +88,8 @@ export class LegacyHtmlAstTransformer implements HtmlAstVisitor {
 
   visitExpansion(ast: HtmlExpansionAst, context: any): any {
     let cases = ast.cases.map(c => c.visit(this, null));
-    return new HtmlExpansionAst(ast.switchValue, ast.type, cases, ast.sourceSpan);
+    return new HtmlExpansionAst(ast.switchValue, ast.type, cases, ast.sourceSpan,
+                                ast.switchValueSourceSpan);
   }
 
   visitExpansionCase(ast: HtmlExpansionCaseAst, context: any): any { return ast; }

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ class TreeBuilder {`
`150`	`150`	`// parse everything in between { and }`
`151`	`151`	`let parsedExp = new TreeBuilder(exp).build();`
`152`	`152`	`if (parsedExp.errors.length > 0) {`
`153`		`- this.errors = this.errors.concat(parsedExp.errors);`
	`153`	`+ this.errors = this.errors.concat(<HtmlTreeError[]>parsedExp.errors);`
`154`	`154`	`return;`
`155`	`155`	`}`
`156`	`156`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,8 @@ export class LegacyHtmlAstTransformer implements HtmlAstVisitor {`
`88`	`88`
`89`	`89`	`visitExpansion(ast: HtmlExpansionAst, context: any): any {`
`90`	`90`	`let cases = ast.cases.map(c => c.visit(this, null));`
`91`		`- return new HtmlExpansionAst(ast.switchValue, ast.type, cases, ast.sourceSpan);`
	`91`	`+ return new HtmlExpansionAst(ast.switchValue, ast.type, cases, ast.sourceSpan,`
	`92`	`+ ast.switchValueSourceSpan);`
`92`	`93`	`}`
`93`	`94`
`94`	`95`	`visitExpansionCase(ast: HtmlExpansionCaseAst, context: any): any { return ast; }`