platform specific lineheight

Sankhadeep Roy · Sankhadeep Roy · commit f404ac40cb2d · 2016-07-03T17:45:45.000+05:30
diff --git a/Components/Themes/light.js b/Components/Themes/light.js
@@ -110,6 +110,8 @@ module.exports = {
         return this.inputPaddingLeft* 8;
     },
 
+    btnLineHeight: (Platform.OS==='ios') ? 20 : 23,
+
     dropdownBg: "#000",
     dropdownLinkColor: "#414142",
 
diff --git a/Components/Widgets/Button.js b/Components/Widgets/Button.js
@@ -83,7 +83,7 @@ export default class Button extends NativeBaseComponent {
 
             fontSize: (this.props.large) ? this.getTheme().btnTextSizeLarge : (this.props.small) ? this.getTheme().btnTextSizeSmall : this.getTheme().btnTextSize,
 
-            lineHeight: (this.props.large) ? 29 : (this.props.small) ? 16 : 20
+            lineHeight: (this.props.large) ? 29 : (this.props.small) ? 16 : this.getTheme().btnLineHeight,
         }
 
         return _.merge(mergedStyle, btnType, this.props.textStyle);

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ export default class Button extends NativeBaseComponent {`
`83`	`83`
`84`	`84`	`fontSize: (this.props.large) ? this.getTheme().btnTextSizeLarge : (this.props.small) ? this.getTheme().btnTextSizeSmall : this.getTheme().btnTextSize,`
`85`	`85`
`86`		`- lineHeight: (this.props.large) ? 29 : (this.props.small) ? 16 : 20`
	`86`	`+ lineHeight: (this.props.large) ? 29 : (this.props.small) ? 16 : this.getTheme().btnLineHeight,`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`return _.merge(mergedStyle, btnType, this.props.textStyle);`