Skip to content

adding signup form for slack#13

Merged
buildmaster merged 2 commits intomasterfrom
new_signup_for_slack
Mar 20, 2019
Merged

adding signup form for slack#13
buildmaster merged 2 commits intomasterfrom
new_signup_for_slack

Conversation

@buildmaster
Copy link
Copy Markdown
Member

@buildmaster buildmaster commented Mar 20, 2019

We're looking to use a new service to aid moderated signups for slack this adds a form we need

@jamesmacfie
Copy link
Copy Markdown
Contributor

Nice :)

I bought this down locally and had unexpected dotenv issues where require('dotenv').load() no longer exists (it worked with require('dotenv') alone though). I see the package.lock file has changed so maybe it's bought in a newer version of dotenv that breaks? May only be an issue on my machine, but it fails to start in heroku and that's the error message you get back that might help.

Looks good to me though - I ran through the fail paths but not the success path as I didn't want to actually submit the form and not be able to check it 😄 Looks good.

It may also be worth adding that page to the header

@buildmaster buildmaster merged commit a3bc4ed into master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants