Skip to content

Commit 3b3354e

Browse files
committed
Merge branch 'upstream_master'
2 parents 246525b + 16945e7 commit 3b3354e

File tree

120 files changed

+5150
-2679
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

120 files changed

+5150
-2679
lines changed

CHANGELOG.md

Lines changed: 154 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,154 @@
1+
BioJava 5.0.0
2+
=============
3+
4+
unreleased
5+
6+
- For short structure selections (e.g. 1abc.A:1-100), ligands within 5A will be included
7+
8+
9+
BioJava 4.2.5
10+
=============
11+
12+
release date: December 7th 2016
13+
This release contains [30](https://github.com/biojava/biojava/compare/biojava-4.2.4...biojava-4.2.5) commits from 7 contributors.
14+
15+
### Bug fixes
16+
17+
* Fix for new phosphositeplus.org format, #610
18+
* org.biojava.nbio.genome.parsers.gff.Location union() and intersect() now work correctly, #355
19+
* Minor addition of crystallographic metadata fields to handle legacy PDB entries
20+
* Jmol interchange format is now mmCIF, allowing for multiletter chain ids
21+
* Update to latest jmol 14.6.2_2016.08.28
22+
* A few minor bug fixes
23+
24+
BioJava 4.2.4
25+
=============
26+
27+
release date: July 29th 2016
28+
This release contains over [17](https://github.com/biojava/biojava/compare/biojava-4.2.3...biojava-4.2.4) commits from 4 contributors.
29+
30+
### Bug fixes
31+
32+
* NCBI links now using https (see [NCBI's announcement](http://www.ncbi.nlm.nih.gov/news/06-10-2016-ncbi-https/) )
33+
* CATH links redirected to new server http://release.cathdb.info/
34+
* SCOP default location now points to the Berkeley server after demise of Scop at MRC LMB
35+
* Fixed important bug in mmCIF writing where structures with multiple models were written with identical coordinates
36+
* Fixed bug in Group cloning where chemical components weren't cloned
37+
* Added utility class for Chromosome mapping
38+
39+
BioJava 4.2.3
40+
=============
41+
42+
release date: July 28th 2016
43+
This release contains over [13](https://github.com/biojava/biojava/compare/biojava-4.2.2...biojava-4.2.3) commits from 2 contributors.
44+
45+
### Bug fixes
46+
47+
* mmCIF file writing: special fields (e.g. containing hyphens) are now correctly written
48+
* General improvements in mmCIF file read and write
49+
50+
BioJava 4.2.2
51+
=============
52+
53+
release date: June 14th 2016
54+
This release contains over [31](https://github.com/biojava/biojava/compare/biojava-4.2.1...biojava-4.2.2) commits from 5 contributors.
55+
56+
### Bug fixes
57+
58+
This is a bug-fix release
59+
60+
* CE-Symm features and bug fixes
61+
- Better data structures for symmetry axes (particularly for hierarchical symmetry)
62+
- Fix bug with symmetry axis positioning
63+
- Optimization includes all symmetry repeats for hierarchical symmetry
64+
* Update of protein modifications to latest version,
65+
- including new glycans and chromophores
66+
- Updating naming definitions to latest conventions
67+
68+
69+
BioJava 4.2.1
70+
=============
71+
72+
release date: May 3rd 2016
73+
This release contains over [31](https://github.com/biojava/biojava/compare/biojava-4.2.0...biojava-4.2.1) commits from 7 contributors.
74+
75+
### Bug fixes
76+
77+
Biojava-structure
78+
79+
- Nucleotide bonds are now generated
80+
- BIO: identifiers are now correctly handled
81+
- Several fixes for CE-Symm
82+
- Substructures now contain seqres groups (isse #449)
83+
- Structures containing insertion codes are now written correctly to mmCIF
84+
- AtomCache now uses the correct default parsing parameters (issue #455)
85+
- Fixed problem with some atom charges that weren't being added
86+
- CATH updated to 4.0.0
87+
- Better ECOD javadocs (issue #452)
88+
89+
Biojava-structure-gui
90+
- Removed javaws dependency (issue #459)
91+
92+
BioJava 4.2.0
93+
=============
94+
95+
release date: March 10th 2016
96+
97+
This release contains over [750](https://github.com/biojava/biojava/compare/6f8d796fee92edbbcd001c33cdae4f15c5480741...biojava-4.2.0) commits from 16 contributors.
98+
99+
### New Features
100+
101+
BioJava 4.2.0 offers many new features, as well several bug-fixes.
102+
103+
General
104+
105+
- Requires Java 7
106+
- Better logging with SLF4J
107+
108+
Biojava-Core
109+
110+
- New SearchIO framework including blast xml parser
111+
112+
Biojava-structure
113+
114+
- Secondary structure assignment (DSSP compatible)
115+
- Multiple Structure Alignments
116+
- New MultipleStructureAlignment datastructure supporting flexible and order-independent alignments
117+
- MultipleMC algorithm
118+
- Can use any pairwise StructureAlignment implementation
119+
- serialize and parse multiple structure alignments as XML files, output as Text, FatCat, FASTA, Rotation Matrices, etc.
120+
- More complete mmCIF and cif parsing
121+
- Parse bonds, sites, charges
122+
- Better support for non-deposited pdb and mmcif files
123+
- Include CE-Symm algorithm for finding internal symmetry (Myers-Turnbull, 2014)
124+
- Replaced internal graph datastructures with Jgraph
125+
- Unified StructureIdentifier framework
126+
- Improved chemical component framework, now by default providing full chemical description by using DownloadChemCompProvider
127+
- Optimised memory usage of Residue/Atoms
128+
129+
Biojava-structure-gui
130+
131+
- MultipleAlignmentGUI for visualizing Multiple Structure Alignments with Jmol
132+
- SymmetryDisplay for visualizing internal symmetry
133+
134+
Biojava-Phylo
135+
136+
- Use Forester 1.038
137+
- Significant bug fixes
138+
- use SubstitutionMatrices in the core module (instead of imported Jalview matrices),
139+
- use Sequence and Compound classes from the alignment module
140+
- provide some Wrapper methods to communicate with forester,
141+
- decouple distance matrix calculation from tree constructor,
142+
- provide methods for common distance matrix calculations and framework for user-defined distances,
143+
- update the forester version to have the correct NJ tree constructor
144+
AND
145+
- correct some of the tree evaluator statistics.
146+
147+
148+
149+
150+
151+
152+
153+
154+

biojava-core/src/main/java/org/biojava/nbio/core/sequence/AccessionID.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@ public void setVersion(Integer version) {
133133

134134
/**
135135
* In case if {@link #getID() } in not unique keeps the alternative id, eg. NCBI GI number.
136+
*
137+
* This may null.
136138
*
137139
* @return
138140
*/

biojava-core/src/test/java/org/biojava/nbio/core/sequence/loader/GenbankProxySequenceReaderTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,10 @@ so it should be done here (manualy).
9999
logger.info("accession id: {}", seq.getAccession().getID());
100100
Assert.assertNotNull(seq.getAccession().getID());
101101
// test GID number
102-
Assert.assertEquals(gi, seq.getAccession().getIdentifier());
103-
logger.info("found identifier '{}'", seq.getAccession().getIdentifier());
104-
102+
if( seq.getAccession().getIdentifier() != null) { // GI: in header now optional. See #596
103+
Assert.assertEquals(gi, seq.getAccession().getIdentifier());
104+
logger.info("found identifier '{}'", seq.getAccession().getIdentifier());
105+
}
105106
// test taxonomy id
106107
logger.info("taxonomy id: {}", seq.getTaxonomy().getID());
107108
Assert.assertNotNull(seq.getTaxonomy().getID());

biojava-genome/src/main/java/org/biojava/nbio/genome/util/ChromosomeMappingTools.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,11 @@
1313
import java.util.List;
1414

1515
/**
16-
* A class that take care of the painful mapping
16+
* A class that can map chromosomal positions to mRNA (coding sequence) positions.
17+
*
18+
* @author Andreas Prlic
1719
*/
20+
1821
public class ChromosomeMappingTools {
1922

2023
private static final Logger logger = LoggerFactory.getLogger(ChromosomeMappingTools.class);
@@ -915,7 +918,7 @@ private static List<Range<Integer>> getCDSExonRangesForward(GeneChromosomePositi
915918
//
916919

917920
/**
918-
* I have a genomic coordinate, where is it in the Gene?
921+
* I have a genomic coordinate, where is it on the mRNA
919922
*
920923
* @param coordinate
921924
* @param chromosomePosition
@@ -1132,7 +1135,7 @@ public static int getCDSPosReverse(int chromPos, List<Integer> exonStarts, List<
11321135
}
11331136

11341137
/**
1135-
* Get the chromosome position mapped onto the mrna CDS transcript position (needs to be divided by 3 to get protein coordinate)
1138+
* Get the chromosome position mapped onto the mRNA CDS transcript position (needs to be divided by 3 to get protein coordinate)
11361139
*
11371140
* @param exonStarts
11381141
* @param exonEnds

biojava-integrationtest/src/test/java/org/biojava/nbio/structure/test/StructureTest.java

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,17 @@
2121
package org.biojava.nbio.structure.test;
2222

2323
import org.biojava.nbio.structure.*;
24+
import org.biojava.nbio.structure.geometry.SuperPositions;
2425
import org.biojava.nbio.structure.io.FileParsingParameters;
2526
import org.biojava.nbio.structure.io.PDBFileParser;
2627
import org.biojava.nbio.structure.io.SSBondImpl;
27-
import org.biojava.nbio.structure.jama.Matrix;
28-
2928
import java.io.IOException;
3029
import java.io.InputStream;
3130
import java.util.List;
3231
import java.util.Set;
3332

33+
import javax.vecmath.Matrix4d;
34+
3435
import org.junit.BeforeClass;
3536
import org.junit.Test;
3637

@@ -41,8 +42,6 @@
4142
* @author Andreas Prlic
4243
* @since 1.5
4344
*/
44-
45-
4645
public class StructureTest {
4746

4847
private static Structure structure;
@@ -266,18 +265,12 @@ public void testMutation() throws Exception {
266265
atoms2[1] = g2.getAtom("CA");
267266
atoms2[2] = g2.getAtom("CB");
268267

268+
Matrix4d transform = SuperPositions.superpose(
269+
Calc.atomsToPoints(atoms1), Calc.atomsToPoints(atoms2));
269270

270-
SVDSuperimposer svds = new SVDSuperimposer(atoms1,atoms2);
271-
272-
273-
Matrix rotMatrix = svds.getRotation();
274-
Atom tran = svds.getTranslation();
275-
276-
Group newGroup = (Group)g2.clone();
277-
278-
Calc.rotate(newGroup,rotMatrix);
271+
Group newGroup = (Group) g2.clone();
279272

280-
Calc.shift(newGroup,tran);
273+
Calc.transform(newGroup, transform);
281274

282275
Atom ca1 = g1.getAtom("CA");
283276
Atom oldca2 = g2.getAtom("CA");

0 commit comments

Comments
 (0)