Skip to content

Commit 33349e7

Browse files
committed
Actually fix MiniMessage conversion bug
1 parent 4133535 commit 33349e7

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

core/src/main/java/be/isach/ultracosmetics/command/SubCommand.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@
33
import be.isach.ultracosmetics.UltraCosmetics;
44
import be.isach.ultracosmetics.config.MessageManager;
55
import be.isach.ultracosmetics.cosmetics.Category;
6+
import net.kyori.adventure.text.Component;
7+
import net.kyori.adventure.text.format.NamedTextColor;
8+
import net.kyori.adventure.text.format.TextDecoration;
69
import org.bukkit.Bukkit;
7-
import org.bukkit.ChatColor;
810
import org.bukkit.command.CommandSender;
911
import org.bukkit.entity.Player;
1012
import org.bukkit.permissions.Permission;
@@ -20,6 +22,7 @@
2022
*/
2123
public abstract class SubCommand {
2224

25+
private final Component prefix = MessageManager.getMessage("Prefix");
2326
private final String name;
2427
private final String description;
2528
private final Permission permission;
@@ -159,6 +162,8 @@ protected void badUsage(CommandSender sender, String usage) {
159162
}
160163

161164
protected void error(CommandSender sender, String error) {
162-
sender.sendMessage(ChatColor.RED.toString() + ChatColor.BOLD + error);
165+
MessageManager.getAudiences().sender(sender).sendMessage(
166+
Component.empty().append(prefix).appendSpace().append(Component.text(error, NamedTextColor.RED, TextDecoration.BOLD))
167+
);
163168
}
164169
}

core/src/main/java/be/isach/ultracosmetics/command/subcommands/SubCommandToggle.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ private void toggle(CommandSender sender, Player targetPlayer, String type, Stri
6666

6767
UltraPlayer target = ultraCosmetics.getPlayerManager().getUltraPlayer(targetPlayer);
6868
if (target == null) {
69-
sender.sendMessage(MessageManager.getMessage("Prefix") + ERROR_PREFIX + "Invalid player.");
69+
error(sender, "Invalid player.");
7070
return;
7171
}
7272

@@ -77,13 +77,13 @@ private void toggle(CommandSender sender, Player targetPlayer, String type, Stri
7777

7878
Optional<Category> categories = Arrays.stream(Category.values()).filter(category -> category.isEnabled() && category.toString().toLowerCase().startsWith(type)).findFirst();
7979
if (!categories.isPresent()) {
80-
sender.sendMessage(MessageManager.getMessage("Prefix") + ERROR_PREFIX + "Invalid category.");
80+
error(sender, "Invalid category.");
8181
return;
8282
}
8383
Category category = categories.get();
8484
CosmeticType<?> matchingType = findCosmetic(category, cosm);
8585
if (matchingType == null) {
86-
sender.sendMessage(MessageManager.getMessage("Prefix") + ERROR_PREFIX + "Invalid cosmetic.");
86+
error(sender, "Invalid cosmetic.");
8787
return;
8888
}
8989
if (target.getCosmetic(category) != null && matchingType == target.getCosmetic(category).getType()) {

core/src/main/java/be/isach/ultracosmetics/config/MessageManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ private void minimessageMigration() {
213213
log.write(SmartLogger.LogLevel.WARNING, "Your messages file is using legacy color codes, it will be upgraded now");
214214
ConfigurationSection config = messagesConfig.fileConfiguration;
215215
LegacyComponentSerializer deserializer = LegacyComponentSerializer.legacyAmpersand();
216-
Pattern percentVarPattern = Pattern.compile("%(\\w+)%");
216+
Pattern percentVarPattern = Pattern.compile("%([\\w-]+)%");
217217
for (String key : config.getKeys(true)) {
218218
if (!config.isString(key)) continue;
219219
// Doing it line by line prevents weird behavior like this:

0 commit comments

Comments
 (0)