Skip to content

Commit ccf719f

Browse files
goekaygoekay
committed
refactor: delete OcppTagServicegetIdTagInfoV12(..) because not used
1 parent 72cb526 commit ccf719f

2 files changed

Lines changed: 1 addition & 36 deletions

File tree

‎src/main/java/de/rwth/idsg/steve/service/OcppTagService.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* @since 03.01.2015
1111
*/
1212
public interface OcppTagService {
13-
ocpp.cs._2010._08.IdTagInfo getIdTagInfoV12(String idTag);
13+
1414
ocpp.cs._2012._06.IdTagInfo getIdTagInfoV15(String idTag);
1515

1616
/**

‎src/main/java/de/rwth/idsg/steve/service/OcppTagServiceImpl.java‎

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import jooq.steve.db.tables.records.OcppTagRecord;
99
import lombok.extern.slf4j.Slf4j;
1010
import ocpp.cp._2012._06.AuthorisationData;
11-
import ocpp.cs._2010._08.AuthorizationStatus;
1211
import org.joda.time.DateTime;
1312
import org.jooq.RecordMapper;
1413
import org.springframework.beans.factory.annotation.Autowired;
@@ -58,40 +57,6 @@ public List<InvalidOcppTag> getInvalidOcppTags() {
5857
.collect(Collectors.toList());
5958
}
6059

61-
@Override
62-
public ocpp.cs._2010._08.IdTagInfo getIdTagInfoV12(String idTag) {
63-
OcppTagRecord record = ocppTagRepository.getRecord(idTag);
64-
ocpp.cs._2010._08.IdTagInfo idTagInfo = new ocpp.cs._2010._08.IdTagInfo();
65-
66-
if (record == null) {
67-
log.error("The user with idTag '{}' is INVALID (not present in DB).", idTag);
68-
idTagInfo.setStatus(AuthorizationStatus.INVALID);
69-
processInvalid(idTag);
70-
} else {
71-
if (record.getBlocked()) {
72-
log.error("The user with idTag '{}' is BLOCKED.", idTag);
73-
idTagInfo.setStatus(AuthorizationStatus.BLOCKED);
74-
75-
// } else if (record.getInTransaction()) {
76-
// log.warn("The user with idTag '{}' is ALREADY in another transaction.", idTag);
77-
// idTagInfo.setStatus(AuthorizationStatus.CONCURRENT_TX);
78-
79-
} else if (record.getExpiryDate() != null && DateTime.now().isAfter(record.getExpiryDate())) {
80-
log.error("The user with idTag '{}' is EXPIRED.", idTag);
81-
idTagInfo.setStatus(AuthorizationStatus.EXPIRED);
82-
83-
} else {
84-
log.debug("The user with idTag '{}' is ACCEPTED.", idTag);
85-
idTagInfo.setStatus(AuthorizationStatus.ACCEPTED);
86-
87-
int hours = settingsRepository.getHoursToExpire();
88-
idTagInfo.setExpiryDate(DateTime.now().plusHours(hours));
89-
idTagInfo.setParentIdTag(record.getParentIdTag());
90-
}
91-
}
92-
return idTagInfo;
93-
}
94-
9560
@Override
9661
public ocpp.cs._2012._06.IdTagInfo getIdTagInfoV15(String idTag) {
9762
OcppTagRecord record = ocppTagRepository.getRecord(idTag);

0 commit comments

Comments
 (0)