Skip to content

Commit bad5736

Browse files
committed
do not process empty ws text msg (Fixes steve-community#66)
1 parent 2a62300 commit bad5736

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

src/main/java/de/rwth/idsg/steve/ocpp/ws/AbstractWebSocketEndpoint.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package de.rwth.idsg.steve.ocpp.ws;
22

3+
import com.google.common.base.Strings;
34
import de.rwth.idsg.steve.config.WebSocketConfiguration;
45
import de.rwth.idsg.steve.ocpp.OcppVersion;
56
import de.rwth.idsg.steve.ocpp.ws.data.CommunicationContext;
@@ -75,6 +76,12 @@ private void handleTextMessage(WebSocketSession session, TextMessage webSocketMe
7576
String incomingString = webSocketMessage.getPayload();
7677
String chargeBoxId = getChargeBoxId(session);
7778

79+
// https://github.com/RWTH-i5-IDSG/steve/issues/66
80+
if (Strings.isNullOrEmpty(incomingString)) {
81+
WebSocketLogger.receivedEmptyText(chargeBoxId, session);
82+
return;
83+
}
84+
7885
WebSocketLogger.receivedText(chargeBoxId, session, incomingString);
7986

8087
CommunicationContext context = new CommunicationContext(session, chargeBoxId);

src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ public static void receivedText(String chargeBoxId, WebSocketSession session, St
3737
log.info("[chargeBoxId={}, sessionId={}] Received: {}", chargeBoxId, session.getId(), msg);
3838
}
3939

40+
public static void receivedEmptyText(String chargeBoxId, WebSocketSession session) {
41+
log.warn("[chargeBoxId={}, sessionId={}] Received empty text message. Will pretend this never happened.", chargeBoxId, session.getId());
42+
}
43+
4044
public static void pingError(String chargeBoxId, WebSocketSession session, Throwable t) {
4145
if (log.isErrorEnabled()) {
4246
log.error("[chargeBoxId=" + chargeBoxId + ", sessionId=" + session.getId() + "] Ping error", t);

0 commit comments

Comments
 (0)