Skip to content

Commit a88b569

Browse files
goekaygoekay
committed
refactor [ci skip]
changes to make findbugs happy: split the RequestTask and made RequestResult a standalone class. moved them both under dto package, which is more suitable. define a charset for "ping" in PingTask.
1 parent 84e6392 commit a88b569

33 files changed

Lines changed: 50 additions & 45 deletions

‎src/main/java/de/rwth/idsg/steve/handler/AbstractOcppResponseHandler.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler;
22

33
import de.rwth.idsg.steve.ocpp.ws.data.OcppJsonError;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import lombok.RequiredArgsConstructor;
66

77
import javax.xml.ws.Response;
@@ -39,7 +39,7 @@ public void handleException(Exception e) {
3939
/**
4040
* Even though we have an error, this object is still a valid response from charge point
4141
* and RequestTask should treat it as such.
42-
* {@link de.rwth.idsg.steve.web.RequestTask#addNewError(java.lang.String, java.lang.Exception)}
42+
* {@link RequestTask#addNewError(java.lang.String, java.lang.Exception)}
4343
* should be used when the request could not be delivered and there is a Java exception.
4444
*/
4545
@Override

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/ChangeAvailabilityResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.ChangeAvailabilityResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/ChangeConfigurationResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.ChangeConfigurationResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/ClearCacheResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.ClearCacheResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/GetDiagnosticsResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.GetDiagnosticsResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/RemoteStartTransactionResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.RemoteStartTransactionResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/RemoteStopTransactionResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.RemoteStopTransactionResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/ResetResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.ResetResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/UnlockConnectorResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.UnlockConnectorResponse;
66

77
/**

‎src/main/java/de/rwth/idsg/steve/handler/ocpp12/UpdateFirmwareResponseHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.rwth.idsg.steve.handler.ocpp12;
22

33
import de.rwth.idsg.steve.handler.AbstractOcppResponseHandler;
4-
import de.rwth.idsg.steve.web.RequestTask;
4+
import de.rwth.idsg.steve.web.dto.RequestTask;
55
import ocpp.cp._2010._08.UpdateFirmwareResponse;
66

77
/**

0 commit comments

Comments
 (0)