Skip to content

Commit 0f257f2

Browse files
committed
stop logging what operation we are executing for which charging station
reason: 1) was it ever useful? 2) since data structures of every other version are mapped to ocpp 1.6 and executed in CentralSystemService16_Service, it is confusing in the log file when the class name appears.
1 parent 3be0002 commit 0f257f2

1 file changed

Lines changed: 0 additions & 20 deletions

File tree

src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ public class CentralSystemService16_Service {
5151

5252
public BootNotificationResponse bootNotification(BootNotificationRequest parameters, String chargeBoxIdentity,
5353
OcppProtocol ocppProtocol) {
54-
log.debug("Executing bootNotification for {}", chargeBoxIdentity);
55-
5654
DateTime now = DateTime.now();
5755

5856
UpdateChargeboxParams params =
@@ -84,17 +82,13 @@ public BootNotificationResponse bootNotification(BootNotificationRequest paramet
8482

8583
public FirmwareStatusNotificationResponse firmwareStatusNotification(
8684
FirmwareStatusNotificationRequest parameters, String chargeBoxIdentity) {
87-
log.debug("Executing firmwareStatusNotification for {}", chargeBoxIdentity);
88-
8985
String status = parameters.getStatus().value();
9086
ocppServerRepository.updateChargeboxFirmwareStatus(chargeBoxIdentity, status);
9187
return new FirmwareStatusNotificationResponse();
9288
}
9389

9490
public StatusNotificationResponse statusNotification(
9591
StatusNotificationRequest parameters, String chargeBoxIdentity) {
96-
log.debug("Executing statusNotification for {}", chargeBoxIdentity);
97-
9892
// Optional field
9993
DateTime timestamp = parameters.isSetTimestamp() ? parameters.getTimestamp() : DateTime.now();
10094

@@ -121,8 +115,6 @@ public StatusNotificationResponse statusNotification(
121115
}
122116

123117
public MeterValuesResponse meterValues(MeterValuesRequest parameters, String chargeBoxIdentity) {
124-
log.debug("Executing meterValues for {}", chargeBoxIdentity);
125-
126118
if (parameters.isSetMeterValue()) {
127119
ocppServerRepository.insertMeterValues(chargeBoxIdentity, parameters.getMeterValue(),
128120
parameters.getConnectorId(), parameters.getTransactionId());
@@ -132,16 +124,12 @@ public MeterValuesResponse meterValues(MeterValuesRequest parameters, String cha
132124

133125
public DiagnosticsStatusNotificationResponse diagnosticsStatusNotification(
134126
DiagnosticsStatusNotificationRequest parameters, String chargeBoxIdentity) {
135-
log.debug("Executing diagnosticsStatusNotification for {}", chargeBoxIdentity);
136-
137127
String status = parameters.getStatus().value();
138128
ocppServerRepository.updateChargeboxDiagnosticsStatus(chargeBoxIdentity, status);
139129
return new DiagnosticsStatusNotificationResponse();
140130
}
141131

142132
public StartTransactionResponse startTransaction(StartTransactionRequest parameters, String chargeBoxIdentity) {
143-
log.debug("Executing startTransaction for {}", chargeBoxIdentity);
144-
145133
InsertTransactionParams params =
146134
InsertTransactionParams.builder()
147135
.chargeBoxId(chargeBoxIdentity)
@@ -161,8 +149,6 @@ public StartTransactionResponse startTransaction(StartTransactionRequest paramet
161149
}
162150

163151
public StopTransactionResponse stopTransaction(StopTransactionRequest parameters, String chargeBoxIdentity) {
164-
log.debug("Executing stopTransaction for {}", chargeBoxIdentity);
165-
166152
int transactionId = parameters.getTransactionId();
167153
String stopReason = parameters.isSetReason() ? parameters.getReason().value() : null;
168154

@@ -191,17 +177,13 @@ public StopTransactionResponse stopTransaction(StopTransactionRequest parameters
191177
}
192178

193179
public HeartbeatResponse heartbeat(HeartbeatRequest parameters, String chargeBoxIdentity) {
194-
log.debug("Executing heartbeat for {}", chargeBoxIdentity);
195-
196180
DateTime now = DateTime.now();
197181
ocppServerRepository.updateChargeboxHeartbeat(chargeBoxIdentity, now);
198182

199183
return new HeartbeatResponse().withCurrentTime(now);
200184
}
201185

202186
public AuthorizeResponse authorize(AuthorizeRequest parameters, String chargeBoxIdentity) {
203-
log.debug("Executing authorize for {}", chargeBoxIdentity);
204-
205187
// Get the authorization info of the user
206188
String idTag = parameters.getIdTag();
207189
IdTagInfo idTagInfo = ocppTagService.getIdTagInfo(idTag);
@@ -213,8 +195,6 @@ public AuthorizeResponse authorize(AuthorizeRequest parameters, String chargeBox
213195
* Dummy implementation. This is new in OCPP 1.5. It must be vendor-specific.
214196
*/
215197
public DataTransferResponse dataTransfer(DataTransferRequest parameters, String chargeBoxIdentity) {
216-
log.debug("Executing dataTransfer for {}", chargeBoxIdentity);
217-
218198
log.info("[Data Transfer] Charge point: {}, Vendor Id: {}", chargeBoxIdentity, parameters.getVendorId());
219199
if (parameters.isSetMessageId()) {
220200
log.info("[Data Transfer] Message Id: {}", parameters.getMessageId());

0 commit comments

Comments
 (0)