Implement ProjectController as Disposable

Vigilans · Vigilans · commit 6194c81f3d1c · 2019-11-27T10:26:16.000+08:00
diff --git a/src/controllers/projectController.ts b/src/controllers/projectController.ts
@@ -3,14 +3,20 @@
 
 import * as fse from "fs-extra";
 import * as path from "path";
-import { commands, ExtensionContext, Uri, window, workspace } from "vscode";
+import { commands, Disposable, ExtensionContext, Uri, window } from "vscode";
+import { instrumentOperation } from "vscode-extension-telemetry-wrapper";
 import * as xml2js from "xml2js";
+import { Commands } from "../commands";
 import { Utility } from "../utility";
 
-export class ProjectController {
-    constructor(public readonly context: ExtensionContext) {
+export class ProjectController implements Disposable {
+    public constructor(public readonly context: ExtensionContext) {
+        context.subscriptions.push(commands.registerCommand(Commands.JAVA_PROJECT_CREATE,
+            instrumentOperation(Commands.JAVA_PROJECT_CREATE, () => this.createJavaProject())));
     }
 
+    public dispose() {}
+
     public async createJavaProject() {
         const javaVersion: number = await this.getJavaVersion();
         if (!javaVersion) {
diff --git a/src/extension.ts b/src/extension.ts
@@ -20,10 +20,7 @@ function activateExtension(operationId: string, context: ExtensionContext) {
     Services.initialize(context);
     Settings.initialize(context);
 
-    const projectController: ProjectController = new ProjectController(context);
-    const instrumented = instrumentOperation(Commands.JAVA_PROJECT_CREATE, () => projectController.createJavaProject());
-    context.subscriptions.push(commands.registerCommand(Commands.JAVA_PROJECT_CREATE, instrumented));
-
+    context.subscriptions.push(new ProjectController(context));
     context.subscriptions.push(new DependencyExplorer(context));
 }
 
