fix: Cannot drag from VS Code's file explorer to Java Project explorer (microsoft#661)

jdneo · web-flow · commit 60091d4c7d66 · 2022-07-12T09:39:42.000+08:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
     "explorer"
   ],
   "engines": {
-    "vscode": "^1.66.0"
+    "vscode": "^1.69.0"
   },
   "repository": {
     "type": "git",
@@ -648,7 +648,7 @@
     "@types/mocha": "^9.1.1",
     "@types/node": "^14.18.21",
     "@types/semver": "^7.3.10",
-    "@types/vscode": "1.66.0",
+    "@types/vscode": "1.69.0",
     "@vscode/test-electron": "^2.1.5",
     "copy-webpack-plugin": "^9.1.0",
     "glob": "^7.2.3",
diff --git a/src/views/DragAndDropController.ts b/src/views/DragAndDropController.ts
@@ -48,17 +48,12 @@ export class DragAndDropController implements TreeDragAndDropController<Explorer
             return;
         }
 
-        let uriList: string[] = [];
-        // an undefined value will be contained with the key 'text/uri-list', so here
-        // we iterate all the entries to get the uri list.
-        // see: https://github.com/microsoft/vscode/issues/152031
-        dataTransfer.forEach((value: DataTransferItem, key: string) => {
-            if (key === Explorer.Mime.TextUriList && value.value) {
-                uriList.push(...(value.value as string).split("\n"));
-            }
-        });
+        const uris: string | undefined = await dataTransfer.get(Explorer.Mime.TextUriList)?.asString();
+        if (!uris) {
+            return;
+        }
 
-        uriList = uriList.map(u => {
+        const uriList: string[] = uris.split(/\r?\n/g).map(u => {
             try {
                 const uri = Uri.parse(u, true /* strict */);
                 if (uri.scheme !== "file") {
