deployment github action#42
Merged
FlorianHockmann merged 1 commit intoJanusGraph:masterfrom Feb 7, 2024
Merged
Conversation
Member
FlorianHockmann
left a comment
FlorianHockmann
left a comment
There was a problem hiding this comment.
This looks good to me in general. I only have one suggestion (see inline comment).
I think we can perform the last remaining steps like setting up a user for PyPi and then publish the first version of janusgraph-python shortly after merging this 😃
pm-osc
force-pushed
the
deployment-action
branch
from
8c4fbd4 to
2353a01
Compare
Signed-off-by: pm-osc <pm2.osc@gmail.com>
pm-osc
force-pushed
the
deployment-action
branch
from
2353a01 to
33af8e4
Compare
FlorianHockmann
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the github action for building the python package and publishing it to PyPI. The proposed name for the JanusGraph-Python package is "janusgraphpython" following the naming convention of the Gremlin-Python package called "gremlinpython".