Remove hardcoded credentials#29
Conversation
Signed-off-by: Debasish Kanhar <dekanhar@in.ibm.com>
Signed-off-by: Debasish Kanhar <dekanhar@in.ibm.com>
…is.yml. Fixes JanusGraph#28 Signed-off-by: Debasish Kanhar <dekanhar@in.ibm.com>
|
@debasishdebs the credentials will still be in the commit history this way. Can you either squash this with the initial commit and push it as a new PR against master? I'll make a new feature branch and update the target afterwards. If you want I can do the squash and push on your behalf. Here's a different workflow option in case it would be easier. I generally use
git checkout initial make your changesgit add -A |
Signed-off-by: Debasish Kanhar <dekanhar@in.ibm.com>
Signed-off-by: Debasish Kanhar <dekanhar@in.ibm.com>
|
@debasishdebs Can you squash all the commits? Remember to only squash only the commits you created so it doesn't auto close again. |
|
@chupman : I tried squashing commits but somehow my older history still remains :-O . Should I go ahead, create a new PR with credentials removed? Then we can delete this PR and branch. I think that way the credentials won't be stored in Git history. Again sorry, as all such things with Git like Squashing commit, and merging are new Stuff to me, and I'm learning as I go. So thank you for that :-) |
|
Once the new PR is created, you can apply your change on top of it. That PR will have credentials removed and also my changes which I've done since last few days also included. |
|
The removal of the credentials has to come first before any additional fixes. To squash try this: this should have an editor open. you want to change all the commits other than There's an article here that also might help. If you run into trouble I can do a PR against your branch to make the changes or we can do a screen share on slack and I can walk you through it. edit: I actually listed the wrong commit, but it has been updated. |
|
Closing as duplicate of #30 |
This PR fixes following:
revert-23-initial-codacy-fixesmasterbranch, we then remove the branchinitial. That way the credentials aren't stored in Git history.