Skip to content

First pass at Codacy cleanup#23

Merged
chupman merged 1 commit intoJanusGraph:initialfrom
chupman:initial-codacy-fixes
Mar 29, 2019
Merged

First pass at Codacy cleanup#23
chupman merged 1 commit intoJanusGraph:initialfrom
chupman:initial-codacy-fixes

Conversation

@chupman
Copy link
Copy Markdown
Member

@chupman chupman commented Mar 28, 2019

Quick pass on low time investment codacy issues

Signed-off-by: Chris Hupman chupman@us.ibm.com

@chupman chupman force-pushed the initial-codacy-fixes branch 5 times, most recently from 36b6404 to fa4bf6c Compare March 29, 2019 00:17
Signed-off-by: Chris Hupman <chupman@us.ibm.com>
@chupman chupman force-pushed the initial-codacy-fixes branch from fa4bf6c to 07a62fa Compare March 29, 2019 00:21
@chupman
Copy link
Copy Markdown
Member Author

chupman commented Mar 29, 2019

Last Codacy error is a false positive that I already fixed. I tried to break it and reapply the fix, but all I accomplished was receiving additional emails from Codacy and making myself look more force-push crazy than usual.

Copy link
Copy Markdown

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chupman chupman merged commit 667f459 into JanusGraph:initial Mar 29, 2019
@chupman chupman deleted the initial-codacy-fixes branch March 29, 2019 03:11
@chupman chupman restored the initial-codacy-fixes branch March 29, 2019 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants