Replace new Buffer() with Buffer.alloc() as it is safer.#3
Open
Eraz1997 wants to merge 1 commit intoJanealter:masterfrom
Open
Replace new Buffer() with Buffer.alloc() as it is safer.#3Eraz1997 wants to merge 1 commit intoJanealter:masterfrom
new Buffer() with Buffer.alloc() as it is safer.#3Eraz1997 wants to merge 1 commit intoJanealter:masterfrom
Conversation
Author
|
Checks on a couple of Windows platforms failed, but it seems to be a node-gyp error when building tests, not the tests failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of NodeJS deprecated the
Bufferconstructor as it is unsafe (source: https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/). These code changes might not work on Node.js ≤ 4.4.x and 5.0.0 — 5.9.x, but this should not be a problem since projects running those versions of NodeJS should use ref-array instead ofref-array-napi.