fix: remove redundant error event listeners in Tunnel class#35
Merged
JacobLinCool merged 3 commits intomainfrom Aug 1, 2025
Merged
fix: remove redundant error event listeners in Tunnel class#35JacobLinCool merged 3 commits intomainfrom
JacobLinCool merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 0f67517 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… binary if missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #34
This pull request simplifies error handling in the
Tunnelclass withinsrc/tunnel.tsby removing redundant event listeners for theerrorevent.Key change:
src/tunnel.ts: Removed.on("error", ...)listeners from bothstdoutandstderrevent handlers in theTunnelclass, as they were redundant and theerrorevent is already handled elsewhere.