Fix: exports.module.default does not exist#20
Open
tstone wants to merge 3 commits intoJS-DevTools:masterfrom
Open
Fix: exports.module.default does not exist#20tstone wants to merge 3 commits intoJS-DevTools:masterfrom
tstone wants to merge 3 commits intoJS-DevTools:masterfrom
Conversation
mquan
added a commit
to mquan/api2ai
that referenced
this pull request
Jul 21, 2023
Details in JS-DevTools/ono#19, It's fixed in JS-DevTools/ono#20 This package is not maintained but it's depended on by swagger-parser
|
Nearly a year later. Any reason this hasn't been merged? |
|
This needs to be merged as any rollup / vitejs build are broken without it |
|
please merge this! :) |
|
Hi @JamesMessinger, any chance to have this PR merged? It would unblock all projects using roolup/vitejs builders |
|
Please merge this PR 🥺🙏 |
|
Can this PR please be merged? The bug is breaking my import of the 'next-swagger-doc' package. I've confirmed that the one-line change fixes the import issue. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a tiny bug where
module.exportsexists butmodule.exports.defaultdoes not. An additional check is added to the conditional before proceeding.