Repository navigation
Refactorings to simplify FireMonkey port #841
Description
See pull request #839 for a detailed discussion. Proposed changes:
- Since FMX uses the type single for coordinates and dimensions, while VCL uses Integer, we should create an lais to avoid having too many
$ifdefin the code. - Some function use the type
HDC, we should try to switch toTCanvasinstead. - We should discuss to throw old and rarely used features overboard, like tiled background and own drawn alpha-blended selection
- Get rid of UtilityImages / VirtualTrees.res, they are also not high-dpi compatible. Maybe draw them at runtime on bitmaps.
- Extract
TVTDataObject,VTDRagManageretc. to own unit.
Activity
livius2 commentedon Nov 7, 2018
All looks ok but
but this one should stay. I use it myself.
I can migrate this to FMX but definitely later. The priority for drawing migration is drawing the header for me.
livius2 commentedon Nov 7, 2018
I can change all to alias TDimension but two questions
I see more problems here.
Overrided procedures can not have TDimension replacement...
joachimmarder commentedon Nov 7, 2018
Changing published properties should not be breaking, so yes. For the events we should consider waiting to the next major version of Virtual TreeView. It will work, but the IDE will show an (unnecessary) warning.
I wonder: Is Firemonkey making actual use of the decimal places that the
Singletype offers, or do you typically have whole number here too?A V8.0 might be a good point to finally merge the branches and make such small breaking changes. There is another event that should be changed (#837).
livius2 commentedon Nov 7, 2018
changes commited
It depend of usage case. Normally we have fraction=0 but you can have some scalling and any calculation can be made by fraction.
joachimmarder commentedon Nov 7, 2018
Not sure how to get these changes and leave out all your other changes. I will apply them manually in master branch at a later time.
livius2 commentedon Nov 7, 2018
I suppose you can cherry-pick this particular commit
livius2 commentedon Nov 9, 2018
Added support of header drawing - its columns and button styles
Still few pixel issues but near to compleated
livius2 commentedon Nov 12, 2018
Added some click events, expand, collapse, header column resize, focus rect..
It looks now really promissing :)
Issue #841: Do not use inline assember on FMX platforms that do not s…