.Net Core support and Cake build support #91
Conversation
Updated code to fix compilation issues for .NetCore Introduced cake.build file to handle compilation/tests/packaging Updated appveyor.yml to use cake script and to push artifact on myGet
|
Hi @gpailler when opening the VS2017 solution I get the following errors: \vmware-host\Shared Folders\Documents\Git\GitHub\SlackAPI\SlackAPI\SlackAPI.NetCore.csproj : error : The project file cannot be found. I'll try to resolve these myself, so this is FYI. |
|
@ibruynin thanks for the comment. I fixed the paths |
|
Basic bot functionalities now work on our raspberry Pi with win 10 iot core and .netstandard1.3 |
|
@ibruynin Nice!. Thanks for the feedback |
|
|
||
| string userName = this.fixture.Config.DirectMessageUser; | ||
| string user = client.Users.First(x => x.name.Equals(userName, StringComparison.InvariantCultureIgnoreCase)).id; | ||
| string user = client.Users.First(x => x.name.Equals(userName, StringComparison.OrdinalIgnoreCase)).id; |
There was a problem hiding this comment.
Why was this changed to Ordinal instead of Invariant?
There was a problem hiding this comment.
Invariant is not supported in .NetCore. And according to this issue, InvariantCultureIgnoreCase usage is often to what we want
Inumedia
left a comment
Inumedia
left a comment
There was a problem hiding this comment.
Aside from the change from invariant to ordinal comparison, this looks good to me.
# Conflicts: # SlackAPI/SlackSocket.cs # appveyor.yml
|
I fixed small conflict related to latest PR applied on master |
|
@Inumedia Probably you should wait before merging this PR. VS2017 final will be available today and I will update appveyor script as soon as they publish official image for VS2017 (it will simplify the appveyor.yml script) |
|
👍 |
…ted nuget packages to latest versions
… AppVeyor manually
|
@Inumedia PR updated with full VS2017 support |
|
Is this far away from being pulled in? |
I introduced new csproj files compatible with VS2017 RC (SlackApi.Netcore.csproj...) because format project.json is abandoned.
Nuget package contains net45, netstandard1.3 and netstandard1.6 assemblies (netstandard1.3 version doesn't support detection of RoutingMessage in external assemblies but is compatible with more platforms like UWP. See https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/ for details)
To build using cake:
https://github.com/dotnet/core/blob/master/release-notes/preview4-download.md
To summarize:
Note: