Skip to content

Conversation

@brantb
Copy link
Contributor

@brantb brantb commented Jun 2, 2017

This adds some missing properties to the User object which are exposed by the users.list endpoint.

I threw in a simple integration test as well, but creating restricted/ultra_restricted users requires a paid plan so I'm not sure what else I can add to it. Suggestions are welcome.

@smorey2
Copy link

smorey2 commented Jun 8, 2017

Would also add:
public string team_id;
public string status;
public string real_name;

And this should be bool:
public bool has_2fa;

@brantb
Copy link
Contributor Author

brantb commented Jun 9, 2017

@Grimace1975 Good catch on the bool type, thanks!

The JSON payload doesn't seem to include a status property, but I applied your other two suggestions.

@Inumedia Inumedia merged commit 4b4edab into Inumedia:master Dec 14, 2017
@gpailler gpailler added this to the 1.0.6 milestone Nov 1, 2018
@brantb brantb deleted the user-properties branch June 24, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants