Merge pull request #293 from bakester14/wcb-issue-292

Inumedia · web-flow · commit 6cc4883b8a44 · 2022-08-29T02:56:44.000-05:00
Don't post as_user unless specified.
diff --git a/SlackAPI/SlackClient.cs b/SlackAPI/SlackClient.cs
@@ -618,7 +618,7 @@ public void Update(
             bool linkNames = false,
             IBlock[] blocks = null,
             Attachment[] attachments = null,
-            bool as_user = false)
+            bool? as_user = null)
         {
             List<Tuple<string, string>> parameters = new List<Tuple<string, string>>();
 
@@ -648,9 +648,9 @@ public void Update(
                    {
                       NullValueHandling = NullValueHandling.Ignore
                    })));
-
-
-         parameters.Add(new Tuple<string, string>("as_user", as_user.ToString()));
+            
+            if (as_user.HasValue)
+                parameters.Add(new Tuple<string, string>("as_user", as_user.ToString()));
 
             APIRequestWithToken(callback, parameters.ToArray());
         }
diff --git a/SlackAPI/SlackTaskClient.cs b/SlackAPI/SlackTaskClient.cs
@@ -607,7 +607,7 @@ public Task<UpdateResponse> UpdateAsync(string ts,
             string parse = null,
             bool linkNames = false,
             Attachment[] attachments = null,
-            bool as_user = false,
+            bool? as_user = null,
             IBlock[] blocks = null)
         {
             List<Tuple<string, string>> parameters = new List<Tuple<string, string>>();
@@ -628,7 +628,8 @@ public Task<UpdateResponse> UpdateAsync(string ts,
             if (attachments != null && attachments.Length > 0)
                 parameters.Add(new Tuple<string, string>("attachments", JsonConvert.SerializeObject(attachments)));
 
-            parameters.Add(new Tuple<string, string>("as_user", as_user.ToString()));
+            if (as_user.HasValue)
+                parameters.Add(new Tuple<string, string>("as_user", as_user.ToString()));
 
             if (blocks != null && blocks.Length > 0)
                 parameters.Add(new Tuple<string, string>("blocks", JsonConvert.SerializeObject(blocks,
@@ -657,7 +658,7 @@ public Task<PostMessageResponse> PostMessageAsync(
             bool? unfurl_links = null,
             string icon_url = null,
             string icon_emoji = null,
-            bool as_user = false,
+            bool? as_user = null,
             string thread_ts = null)
         {
             List<Tuple<string,string>> parameters = new List<Tuple<string,string>>();
@@ -697,8 +698,8 @@ public Task<PostMessageResponse> PostMessageAsync(
             if (!string.IsNullOrEmpty(icon_emoji))
                 parameters.Add(new Tuple<string, string>("icon_emoji", icon_emoji));
 
-            if (as_user)
-                parameters.Add(new Tuple<string, string>("as_user", true.ToString()));
+            if (as_user.HasValue)
+                parameters.Add(new Tuple<string, string>("as_user", as_user.ToString()));
 
             if (!string.IsNullOrEmpty(thread_ts))
                 parameters.Add(new Tuple<string, string>("thread_ts", thread_ts));

Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,7 @@ public void Update(`
`618`	`618`	`bool linkNames = false,`
`619`	`619`	`IBlock[] blocks = null,`
`620`	`620`	`Attachment[] attachments = null,`
`621`		`- bool as_user = false)`
	`621`	`+ bool? as_user = null)`
`622`	`622`	`{`
`623`	`623`	`List<Tuple<string, string>> parameters = new List<Tuple<string, string>>();`
`624`	`624`
`@@ -648,9 +648,9 @@ public void Update(`
`648`	`648`	`{`
`649`	`649`	`NullValueHandling = NullValueHandling.Ignore`
`650`	`650`	`})));`
`651`		`-`
`652`		`-`
`653`		`- parameters.Add(new Tuple<string, string>("as_user", as_user.ToString()));`
	`651`	`+`
	`652`	`+ if (as_user.HasValue)`
	`653`	`+ parameters.Add(new Tuple<string, string>("as_user", as_user.ToString()));`
`654`	`654`
`655`	`655`	`APIRequestWithToken(callback, parameters.ToArray());`
`656`	`656`	`}`