Fix: PHP 7.4 cli logs in stderr #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstrojny
approved these changes
Feb 26, 2020
Contributor
|
Thank you! |
baohx2000
pushed a commit
to pagely/http-mock
that referenced
this pull request
Apr 7, 2020
* tests: simulating the situation of PHP 7.4 stderr output * fix: patch to clean stderr output based on the keywords * chore: adding PHP 7.4 to travis * fix: forgot to wipe the error output after the test
|
Can you push a new release so we can update the package with composer easily and not to have to update like that Would be very great 😄 |
Contributor
|
Sure, done, 0.13.0 is out |
|
Thank you ! PS: The package is not auto updated on packagist, I triggered the refresh manually; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #53 and aims to continue the PR #50.
Thanks @mtils and @lstrojny for the help in investigating and proposing a solution!