Fix: PHP 7.4 cli logs in stderr (#55)

gabfr · web-flow · commit b2b4f2774d34 · 2020-02-27T10:05:17.000+01:00
* tests: simulating the situation of PHP 7.4 stderr output

* fix: patch to clean stderr output based on the keywords

* chore: adding PHP 7.4 to travis

* fix: forgot to wipe the error output after the test
diff --git a/.travis.yml b/.travis.yml
@@ -4,6 +4,7 @@ php:
   - 7.1
   - 7.2
   - 7.3
+  - 7.4
 
 before_script:
   - composer install
diff --git a/src/Server.php b/src/Server.php
@@ -119,4 +119,46 @@ private function pollWait()
             }
         }
     }
+
+    public function getIncrementalErrorOutput()
+    {
+        return self::cleanErrorOutput(parent::getIncrementalErrorOutput());
+    }
+
+    public function getErrorOutput()
+    {
+        return self::cleanErrorOutput(parent::getErrorOutput());
+    }
+
+    private static function cleanErrorOutput($output)
+    {
+        if (!trim($output)) {
+            return '';
+        }
+
+        $errorLines = [];
+
+        foreach (explode(PHP_EOL, $output) as $line) {
+            if (!$line) {
+                continue;
+            }
+
+            if (!self::stringEndsWithAny($line, ['Accepted', 'Closing', ' started'])) {
+                $errorLines[] = $line;
+            }
+        }
+
+        return $errorLines ? implode(PHP_EOL, $errorLines) : '';
+    }
+
+    private static function stringEndsWithAny($haystack, array $needles)
+    {
+        foreach ($needles as $needle) {
+            if (substr($haystack, (-1 * strlen($needle))) === $needle) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }
diff --git a/tests/AppIntegrationTest.php b/tests/AppIntegrationTest.php
@@ -207,6 +207,24 @@ static function ($request) {
         $this->assertSame('second', $this->client->get('/')->send()->getBody(true));
     }
 
+    public function testServerLogsAreNotInErrorOutput()
+    {
+        $this->client->delete('/_all');
+
+        $expectedServerErrorOutput = '[404]: (null) / - No such file or directory';
+
+        self::$server1->addErrorOutput('PHP 7.4.2 Development Server (http://localhost:8086) started' . PHP_EOL);
+        self::$server1->addErrorOutput('Accepted' . PHP_EOL);
+        self::$server1->addErrorOutput($expectedServerErrorOutput . PHP_EOL);
+        self::$server1->addErrorOutput('Closing' . PHP_EOL);
+
+        $actualServerErrorOutput = self::$server1->getErrorOutput();
+
+        $this->assertEquals($expectedServerErrorOutput, $actualServerErrorOutput);
+
+        self::$server1->clearErrorOutput();
+    }
+
     private function parseRequestFromResponse(GuzzleResponse $response)
     {
         $body = unserialize($response->getBody());
