This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Series str contains#793
Merged
AlexanderKalistratov merged 6 commits intoIntelPython:masterfrom Apr 7, 2020
Merged
Conversation
densmirn
reviewed
Apr 2, 2020
Contributor
densmirn
left a comment
densmirn
left a comment
There was a problem hiding this comment.
I would also add test to check parameters with invalid values.
| import numba | ||
| from numba.types import (Boolean, Integer, NoneType, | ||
| Omitted, StringLiteral, UnicodeType) | ||
| Omitted, StringLiteral, UnicodeType, Number, Set) |
Contributor
There was a problem hiding this comment.
I don't see usage of Number and Set.
Contributor
There was a problem hiding this comment.
Again, I don't see usage of Number and Set.
…ies_str_contains
densmirn
reviewed
Apr 3, 2020
|
|
||
| def hpat_pandas_stringmethods_contains_impl(self, pat, case=True, flags=0, na=None, regex=True): | ||
| if flags != 0: | ||
| raise ValueError('Parameter flags can be only 0.') |
Contributor
There was a problem hiding this comment.
I propose to do something like that.
Suggested change
| raise ValueError('Parameter flags can be only 0.') | |
| raise SDCLimitation("Method contains(). Unsupported parameter. Given 'flags' != 0") |
| import numba | ||
| from numba.types import (Boolean, Integer, NoneType, | ||
| Omitted, StringLiteral, UnicodeType) | ||
| Omitted, StringLiteral, UnicodeType, Number, Set) |
Contributor
There was a problem hiding this comment.
Again, I don't see usage of Number and Set.
sdc/tests/test_series.py
Outdated
|
|
||
| with self.assertRaises(TypingError) as raises: | ||
| hpat_func(s, pat, na=0) | ||
| msg = 'Method contains(). The object na' |
Contributor
There was a problem hiding this comment.
Please provide full error message.
densmirn
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.