Skip to content

PR - Fix extract_text_from_element()and find_element*() to find_element() - #6438

Merged
elulcao merged 4 commits into
InstaPy:masterfrom
elulcao:instapy-6352
Jan 19, 2022
Merged

PR - Fix extract_text_from_element()and find_element*() to find_element()#6438
elulcao merged 4 commits into
InstaPy:masterfrom
elulcao:instapy-6352

Conversation

@elulcao

@elulcao elulcao commented Dec 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Do not include any personal data.

Fixes # (issue)
#6352
*is_private_profile() when sometimes NoneType is returned

  • Added filter in extract_text_from_element() for non-username elements.
  • Fixed is_private_profile() when 'NoneType' object is not subscriptable
  • Fixed find_element*() to find_element()
    • Functionality is the same, but now selenium 4 uses find_element()

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Manual Test,

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project, black -t py34
  • My changes generate no new warnings

@elulcao
Updated getUserData() and find_element*
74170fb 
Signed-off-by: elulcao <elulcao@icloud.com>
@elulcao
Updated getUserData() and find_element*
7cf1303 
Signed-off-by: elulcao <elulcao@icloud.com>
@elulcao
Updated getUserData() and find_element*
0b898ec 
Signed-off-by: elulcao <elulcao@icloud.com>
This was linked to issues Dec 12, 2021
[BUG] Tries to lookup and follow non-existent users #6352
Closed
UserWarning: find_elements_by_* commands are deprecated. Please use find_elements() instead #6393
Closed
inappropriate, user_name, is_video, reason, scope #6435
Closed
@elulcao
Updated getUserData() and find_element*
2f1d6a5 
Signed-off-by: elulcao <elulcao@icloud.com>
lukesikora
lukesikora approved these changes Dec 17, 2021
View reviewed changes

@lukesikora lukesikora left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elulcao
elulcao requested a review from breuerfelix December 18, 2021 20:56
@elulcao

elulcao commented Jan 12, 2022

Copy link
Copy Markdown
Collaborator Author

Hi @breuerfelix
hope you are doing good, happy 2022 ✌️
if you have a chance to take a look to this PR would be nice,
let me know any questions or comments

@gabinfoulard

gabinfoulard commented Jan 13, 2022

Copy link
Copy Markdown

@breuerfelix we need your verification !!

@maury37

maury37 commented Jan 17, 2022

Copy link
Copy Markdown

Hi @breuerfelix,
Any chance you can have a look at this PR ?
We're blocked for now !
Thanks

@elulcao
elulcao merged commit 2a157d4 into InstaPy:master Jan 19, 2022
@elulcao
elulcao deleted the instapy-6352 branch January 19, 2022 03:59
@Tolmino

Tolmino commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

after that mayor change to way to use By from selenium.webdriver.common.by
i have a not working instapy....

the error i have is that:
in instapy.py, line 1990, in like_by_tags self.logger,
in like_util.py, line 619, in check_link media = post_page [0] ["shortcode_media"] KeyError:0

i think that my webdriver is too old for use By ....
what do you think ?

i'm using now geckodriver in 64bit version 0.30.0
firefox is in version 68.9.0esr

what is right version of geckodriver i must use ?
thanks in advance

kharazian pushed a commit to kharazian/InstaPy that referenced this pull request Sep 3, 2022
@elulcao @kharazian
PR - Fix extract_text_from_element()and find_element*() to `find_…
d84872c 
…element()` (InstaPy#6438)

* Updated getUserData() and find_element*
Signed-off-by: elulcao <elulcao@icloud.com>

Thanks @breuerfelix for reviewing, 🚀 
People in this thread please let me know if something is not OK, IG changed a lot these days. 🤗 @her
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breuerfelix breuerfelix breuerfelix approved these changes
+1 more reviewer
@lukesikora lukesikora lukesikora approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

6 participants

@elulcao @gabinfoulard @maury37 @Tolmino @breuerfelix @lukesikora