Fixing HTML change breakin LIKE and COMMENT - #5296
Conversation
|
it worked, THX!!! X) |
| "unlike": "//section/span/button/span[@aria-label='Unlike']", | ||
| } | ||
| xpath["like_image"] = { "like": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Like']", | ||
| "unlike": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Unlike']", |
There was a problem hiding this comment.
Change the length of the rows to pass the test
| } | ||
| xpath["like_image"] = { | ||
| "like": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Like']", | ||
| "unlike": "/html/body/div[1]/section/main/div/div/article/div[2]/section[1]/span[1]/button[*[local-name()='svg']/@aria-label='Unlike']", |
There was a problem hiding this comment.
this row is still too long
There was a problem hiding this comment.
I'm not sure, but try to format the file with black and check the tox.ini file
There was a problem hiding this comment.
I suggest using a relative path instead of an absolute path
try using:
xpath["like_image"] = { "like": "//section/span/button[*[local-name()='svg']/@aria-label='Like']", "unlike": "//section/span/button[*[local-name()='svg']/@aria-label='Unlike']", }
wrong file name
…neasz/InstaPy into bugfix/fixing-like-comment_html_change
…allation failing when it tries to install PyYAML-5.3, and it fails with error message: PyYAML requires Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.* but the running Python is 3.4.8
|
I have decided to remove Python 3.4.8 from tests in .travis.yml as:
The fix would be to replace This is the error caused during the build for testing in travis-ci
|
| [testenv] | ||
| deps = | ||
| -rrequirements.txt | ||
| -r requirements.txt |
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Changes tested and the fix the issue locally.
|
I just updated instapy and to be sure I also edited the code inside the xpath_compile.py Picture are being liked but comments still not work... I dont even know if hes trying to comment because it just printed "--> not commented" and no error... |
Comments do work |
|
thank you guys |
|
Working and ready to merge? 😄 |
Yes @timgrossmann :) |
8 participants
No description provided.