Skip to content

BUG: Use GNU tar instead of MacOS tar for checkpoint option#283

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
SimonRit:gtar
Sep 4, 2024
Merged

BUG: Use GNU tar instead of MacOS tar for checkpoint option#283
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
SimonRit:gtar

Conversation

@SimonRit
Copy link

@SimonRit SimonRit commented Sep 4, 2024

The action started failing with the message:

tar: Option --checkpoint=10000 is not supported

See here for the result before the patch here after the patch.

@dzenanz dzenanz mentioned this pull request Sep 4, 2024
Merged
dzenanz
dzenanz approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the remote modules broke recently, hopefully this will restore them?

@dzenanz dzenanz requested a review from thewtex September 4, 2024 14:37
@SimonRit
Copy link
Author

SimonRit commented Sep 4, 2024

There is also a disk space issue with macos arm, see here, but I don't know if it's the case on all remotes.

@dzenanz dzenanz merged commit 601dccf into InsightSoftwareConsortium:master Sep 4, 2024
@dzenanz
Copy link
Member

dzenanz commented Sep 4, 2024

The out of space issue is also present here: https://github.com/dzenanz/ITKMontage/actions/runs/10704742693/job/29678469324
but this patch is a move in the right direction.

@dzenanz
Copy link
Member

dzenanz commented Sep 4, 2024

Simon, could you look into python-build-workflow / build-macos-arm-py (9): No space left on device issue? Maybe the same virtual machine is used for all the arm packages? We could solve it by clearing the cache? Or reusing the cached files?

@SimonRit SimonRit deleted the gtar branch September 5, 2024 15:22
@SimonRit SimonRit mentioned this pull request Sep 6, 2024
Merged
@SimonRit
Copy link
Author

SimonRit commented Sep 6, 2024

Simon, could you look into python-build-workflow / build-macos-arm-py (9): No space left on device issue? Maybe the same virtual machine is used for all the arm packages? We could solve it by clearing the cache? Or reusing the cached files?

See #284, let me know there if this is a good enough solution!

@thewtex
Copy link
Member

thewtex commented Sep 6, 2024

cherry-picked to release.

thewtex added a commit to thewtex/ITKRemoteModuleBuildTestPackageAction that referenced this pull request Sep 6, 2024
@thewtex
COMP: Bump ITKPythonPackage version for macOS Python build fixes
3b7ad2f 
Adds:

- InsightSoftwareConsortium/ITKPythonPackage#283
- InsightSoftwareConsortium/ITKPythonPackage#284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonRit @dzenanz @thewtex