ENH: Name and type command line options of Windows module PowerShell script#252
Merged
tbirdso merged 1 commit intoInsightSoftwareConsortium:masterfrom Feb 22, 2023
Merged
Conversation
SimonRit
force-pushed
the
PowershellArgs
branch
from
da6a4f8 to
df0ca57
Compare
Author
|
(The last force-push is only a slight change of the doc.) |
SimonRit
force-pushed
the
PowershellArgs
branch
from
df0ca57 to
1dcfd96
Compare
tbirdso
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at improving the management of arguments in
windows-download-cache-and-build-module-wheels.ps1following problems encountered in RTKConsortium/RTK#535, namely passing multiple cmake options on the command line. The difference in the behaviors of PowerShell and Python args calls for another scripting language in my opinion (see #250 discussion) but this PR is an improvement over #248 in terms of clarity and consistency with other platforms. It is not backward compatible with it but that is probably ok since it is a recent change. See https://github.com/RTKConsortium/RTK/actions/runs/4243933294/jobs/7377339692 and https://github.com/RTKConsortium/RTK/actions/runs/4243933347 for successful use.