ENH: Support iterative ITK module dependencies#243
Merged
tbirdso merged 4 commits intoInsightSoftwareConsortium:masterfrom Dec 16, 2022
Merged
ENH: Support iterative ITK module dependencies#243tbirdso merged 4 commits intoInsightSoftwareConsortium:masterfrom
tbirdso merged 4 commits intoInsightSoftwareConsortium:masterfrom
Conversation
dzenanz
reviewed
Dec 14, 2022
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Looks good on a glance. Someone should review this more carefully.
Contributor
Author
|
Testing has passed 🟢 see links in PR description |
thewtex
reviewed
Dec 15, 2022
Member
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
Awesome!!
LGTM!
Todos:
- Squash the WIP
- Add documentation to the README.
- In the documentation update, it would be helpful to mention that the order will matter -- for modules with a complex dependency tree, the base modules should be listed first.
Formalizes build steps on respective platforms for building modules that depend on other modules. Adapted from ITKBSplineGradient, ITKUltrasound, and other ITK modules whose build procedures include building at least one other ITK module before the target module itself.
tbirdso
force-pushed
the
module-deps-script
branch
from
d3863d1 to
25e4f60
Compare
Contributor
Author
|
@thewtex I've addressed your comments, please take a look through updated documentation to verify. |
tbirdso
commented
Dec 15, 2022
thewtex
reviewed
Dec 16, 2022
tbirdso
force-pushed
the
module-deps-script
branch
from
25e4f60 to
1ada74e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formalizes build steps on respective platforms for building modules that
depend on other modules.
Adapted from ITKBSplineGradient, ITKUltrasound, and other ITK modules
whose build procedures include building at least one other ITK module
before the target module itself.
References:
https://github.com/InsightSoftwareConsortium/ITKBSplineGradient/blob/master/.github/workflows/build-test-package.yml#L164
https://github.com/KitwareMedical/ITKUltrasound/blob/master/.github/workflows/build-test-package.yml#L174
Testing at:
ITKSplitComponents (easy case, no module dependencies)
https://github.com/tbirdso/ITKSplitComponents/actions/runs/3698786787
ITKBSplineGradient (medium case, one module dependency)
https://github.com/InsightSoftwareConsortium/ITKBSplineGradient/actions/runs/3698776628/jobs/6265388050
ITKUltrasound (hard case, five module dependencies)
https://github.com/tbirdso/ITKUltrasound/actions/runs/3698825230/jobs/6265488024
EDIT: Testing has passed 🟢