ENH: Modular archive download script on Linux#241
Merged
tbirdso merged 1 commit intoInsightSoftwareConsortium:masterfrom Dec 12, 2022
Merged
ENH: Modular archive download script on Linux#241tbirdso merged 1 commit intoInsightSoftwareConsortium:masterfrom
tbirdso merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
Separates step for pulling build artifacts into a standalone script that is called by the central download-and-build script. The modular approach allows ITK modules with more complex build steps (OpenCL, etc) to use the download script directly instead of forking and altering the download script, thus reducing the maintenance burden for those ITK modules.
Contributor
Author
|
This change is in support of InsightSoftwareConsortium/ITKCLEsperanto#50 which previously forked ITKPythonPackage's manylinux download script. |
dzenanz
approved these changes
Dec 12, 2022
Contributor
Author
|
ITKSplitComponents Linux tests passed: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3676857336/attempts/1 Windows failures are unrelated as this PR solely deals with Linux scripts. I believe failures are due to these changes being in my fork at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates step for pulling build artifacts into a standalone script that is called by the central download-and-build script. The modular approach allows ITK modules with more complex build steps (OpenCL, etc) to use the download script directly instead of forking and altering the download script, thus reducing the maintenance burden for those ITK modules.
Local test has passed, will test on ITKSplitComponents before merge.
EDIT: Testing at https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3676857336