Skip to content

ENH: Add package with itk-wasm build #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thewtex merged 7 commits into from
Feb 14, 2023
Merged

ENH: Add package with itk-wasm build #55

thewtex merged 7 commits into from
Feb 14, 2023

Conversation

@PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Jan 27, 2023 •
edited
Loading

There is a npm run build script that needs a couple fixes in itk-wasm to work

Problem in bindgen step:

> npx itk-wasm -s ./mesh-to-polydata -b emscripten-build bindgen --package-name mesh-to-polydata --package-description "Convert an ITK Mesh to a simple data structure compatible with vtkPolyData." --repository 'https://github.com/InsightSoftwareConsortium/ITKMeshToPolyData'

node:fs:2831
  handleErrorFromBinding(ctx);
  ^

Error: ENOENT: no such file or directory, copyfile '/home/paul/src/itk-stuff/ITKMeshToPolyData/examples/wasm/node_modules/itk-wasm/src/bindgen/typescript-resources/.npmignore' -> 'typescript/.npmignore'

Same error on typescript/.nojekyll

Also, after working around above by calling itk-wasm-cli from source tree, output has Typescript build error, cannot find PixelType.

@PaulHax PaulHax marked this pull request as ready for review January 27, 2023 21:05
@thewtex
ENH: Bump itk-wasm to 1.0.0-b.71
a77ed2e
@thewtex
STYLE: Rename mesh-to-polydata to mesh-to-poly-data
58730f9 
So the generated function names, etc. are "PolyData" instead of
"Polydata."
@thewtex
ENH: Move wasm/ to top level
4c3df79 
This allows us to build the ITK module sources and use the current ITK module sources in the wasm build (as opposed to the Docker image contents).
@thewtex
Copy link
Member

thewtex commented Feb 14, 2023

Pushing additional commits for discussion.

@thewtex thewtex merged commit 5aee1ae into InsightSoftwareConsortium:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulHax @thewtex