Potential fix for code scanning alert no. 5: Workflow does not contain permissions#874
Draft
Potential fix for code scanning alert no. 5: Workflow does not contain permissions#874
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Member
|
hi @lenucksi. As this was suggested by Copilot, how would you go about testing if this works? We could merge to main, and then check if (a) the workflow still runs, and (b) the code scanning alert goes away? I don't know of other ways to test github actions locally. |
spier
added
the
Type - Maintenance / Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/InnerSourceCommons/InnerSourcePatterns/security/code-scanning/5
To fix the problem, we should add a
permissionsblock to the workflow file.github/workflows/book.yml. The block should be added at the workflow root (top-level, aftername:and beforejobs:), so the permissions apply to all jobs in the workflow. The least privilege required iscontents: writeso the job can push changes to the repo (required by the auto-commit step). Other permissions (such aspull-requests: write) are not required for this workflow, as it does not modify pull requests or other resources. The block should be added after the workflowname:and before thejobs:key (best practice is before any uses of the jobs).No imports or additional methods/definitions are needed; it's a change to the workflow configuration only.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.