Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 63.43% 65.44% +2.00%
==========================================
Files 34 35 +1
Lines 2210 2266 +56
==========================================
+ Hits 1402 1483 +81
+ Misses 808 783 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
karel-rehor
left a comment
There was a problem hiding this comment.
started to review. But the global declaration of DEFAULT_WRITE_NO_SYNC seems to be in an odd place.
karel-rehor
left a comment
There was a problem hiding this comment.
This is looking good, but I can't help but feel that there is perhaps some unnecessary duplicated lines of code in write_client/service/write_service.py
karel-rehor
left a comment
There was a problem hiding this comment.
OK looks good to me. Tests run locally. Changes all make sense. 🚴 🏁
|
Maybe this hasn't been added to a new release yet? The Repo and my installed version is reporting 0.13.0. which looks like it was released 3 weeks ago and this was just approved last week. |
@dburton-influxdata , you can always check the CHANGELOG.md to see what features comes into which release. This change goes into the upcoming |
|
@jansimonb yes, I am doing some v1 to V3 data migration development and testing. I believe I was able to patch my installed version with your fix last night. However our test run using the no_sync=True didn't show any time savings. I am wanting to test with the gzip feature possibly today as well. Did you test the no_sync=True option to verify any write performance gains with V3? |
Yes, I tested it against a local docker-installed influxdb3 server. It is much faster with With no_sync=false: With no_sync=true: One option is to set the with InfluxDBClient3(token=token, host=host, database=db,
write_client_options=write_client_options(
write_options=WriteOptions(
write_type=WriteType.synchronous,
write_precision=WritePrecision.US,
no_sync=True
)
)) as _client:or you can also set it via env: os.environ["INFLUX_HOST"] = host
os.environ["INFLUX_TOKEN"] = token
os.environ["INFLUX_DATABASE"] = db
os.environ["INFLUX_WRITE_NO_SYNC"] = "true"
with InfluxDBClient3.from_env() as _client:But please note that this change is still not released yet. |
|
Jan, Thank you for your response and the examples. I believe I go tit to work for our initial testing and I look forward to the updated release. |
|
Question: How big was the data set that you used for testing? |
I tested just with writing a single record. For a single record the saved time approximately equals to the wal-flush-interval set on server. For larger dataset this can be different based the overall WAL configuration. |
|
@dburton-influxdata , fyi, the feature was released. |
|
@jansimonb Did this release include the should_gzip feature also get released? Either way, do you know or can you find out if we can gzip the query response (payload)? |

Proposed Changes
Support fast writes without waiting for WAL persistence:
WriteOptions.no_sync) added:Truevalue means faster write but without the confirmation thatthe data was persisted. Default value:
False.INFLUX_WRITE_NO_SYNC)."nanosecond","microsecond","millisecond","second"(in addition to the existing"ns","us","ms","s").Checklist