fix: Fix module issue mentioned in #178#179
Merged
GouravSardana merged 4 commits intoIndianOpenSourceFoundation:masterfrom Mar 26, 2022
lainq:master
Merged
fix: Fix module issue mentioned in #178#179GouravSardana merged 4 commits intoIndianOpenSourceFoundation:masterfrom lainq:master
GouravSardana merged 4 commits intoIndianOpenSourceFoundation:masterfrom
lainq:master
Conversation
Contributor
Author
|
Oof. I accidentally included the build files. Ill reopen the pull request with the changes |
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
@pranavbaburaj click on files which you edited and see there were few warnings related to import sequencing and few others |
Contributor
Author
|
Ill fix it in a bit |
Contributor
Author
|
@GouravSardana, when i ran through the errors. most of the errors are wrong. The stuff they say doesn't exist actually does exist |
Member
|
LGTM, I tested in local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#178
Closes: #178