Skip to content

update hashes for 2.3.0#15

Merged
fedorov merged 3 commits intoImagingDataCommons:mainfrom
sebpretzer:main
Apr 4, 2025
Merged

update hashes for 2.3.0#15
fedorov merged 3 commits intoImagingDataCommons:mainfrom
sebpretzer:main

Conversation

@sebpretzer
Copy link
Contributor

@sebpretzer sebpretzer commented Apr 4, 2025

Closes #13

This PR updates the version and hashes for s5cmd 2.3.0.

OPEN QUESTION:
Like all over-eager engineers, I attempted to automate this process with scripts/update_s5cmdUrls.cmake.py. The changes in s5cmdUrls.cmake were auto-generated via:

python scripts/update_s5cmdUrls.cmake.py -c https://github.com/peak/s5cmd/releases/download/v2.3.0/s5cmd_checksums.txt

I decided to add this to the PR, since I thought it could be useful in the future. @fedorov is this useful to you, or should I remove it from the PR?

@sebpretzer sebpretzer changed the title update hashes; add script to auto-generate hashes update hashes for 2.3.0 Apr 4, 2025
@fedorov
Copy link
Member

fedorov commented Apr 4, 2025

I decided to add this to the PR, since I thought it could be useful in the future. @fedorov is this useful to you, or should I remove it from the PR?

Looks very useful to me, thank you! @jcfr please comment if you have concerns!

I hope the CI errors should be easy to address - quoting from the error log:

If you are seeing this message in CI, reproduce locally with: pre-commit run --all-files.
To run pre-commit as part of git workflow, use pre-commit install.

@sebpretzer
Copy link
Contributor Author

sebpretzer commented Apr 4, 2025

I cleaned up the formatting issues. Note: I did ignore one print statement, let me know if I should switch to proper logging.

@sebpretzer
Copy link
Contributor Author

sebpretzer commented Apr 4, 2025 •
edited
Loading

Apologies for not attempting the tests. I have fixed the tests, and run them on my personal machine:

python -m pytest -ra --cov --cov-report=xml --cov-report=term
=============================================== test session starts ===============================================
platform darwin -- Python 3.11.8, pytest-8.3.5, pluggy-1.5.0
rootdir: /Users/sebastianpretzer/git/s5cmd-python-distributions
configfile: pyproject.toml
testpaths: tests
plugins: cov-6.1.0
collected 3 items                                                                                                 

tests/test_executable.py ..                                                                                 [ 66%]
tests/test_package.py .                                                                                     [100%]

================================================= tests coverage ==================================================
________________________________ coverage: platform darwin, python 3.11.8-final-0 _________________________________

Name                                                                                   Stmts   Miss  Cover
----------------------------------------------------------------------------------------------------------
/opt/homebrew/Caskroom/miniforge/base/lib/python3.11/site-packages/s5cmd/__init__.py      21      2    90%
/opt/homebrew/Caskroom/miniforge/base/lib/python3.11/site-packages/s5cmd/_version.py      12      2    83%
----------------------------------------------------------------------------------------------------------
TOTAL                                                                                     33      4    88%
Coverage XML written to file coverage.xml
================================================ 3 passed in 0.22s ================================================

@fedorov fedorov merged commit 7101e8c into ImagingDataCommons:main Apr 4, 2025
12 checks passed
@fedorov
Copy link
Member

fedorov commented Apr 4, 2025

@sebpretzer thank you for your contribution!

@jcfr
Copy link
Collaborator

jcfr commented Apr 4, 2025

Thanks @sebpretzer and @fedorov

Re: Update of URLs

That makes sense. I would suggest to further improve by adding a bump session to the nox file similar to what was done here:
https://github.com/scikit-build/cmake-python-distributions/blob/main/noxfile.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for 2.3.0

3 participants

@sebpretzer @fedorov @jcfr