Report required CI checks for skipped paths - #9498
Open
CyrilWaechter wants to merge 2 commits into
Open
CyrilWaechter wants to merge 2 commits into
CyrilWaechter wants to merge 2 commits into
Conversation
The required compile-and-test checks come from ci.yml, which is path-filtered. A workflow skipped by path filtering leaves its required checks pending forever, so bonsai-only pull requests were blocked. Trigger the workflow unconditionally, detect relevant changes in a changes job, and skip the heavy matrix job with an if condition (a job skipped by a conditional is reported as success). Generated with the assistance of an AI coding tool.
dorny/paths-filter only applies negated ('!') rules with the
some-with-excludes predicate quantifier. With the default 'some',
the '!src/ifcopenshell-python/docs/**' rule makes the filter match
every file outside docs, so unrelated changes (e.g. a new workflow
file) incorrectly trigger the full build.
Generated with the assistance of an AI coding tool.
Contributor
Author
|
Posted the full comparison over on #9454 so the alternatives sit in one place: #9454 (comment) Short version: #9454 and this PR touch the same lines in |
CyrilWaechter
added
the
github_actions
CyrilWaechter
added this pull request to stack #9503
September 15, 2026 11:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compile-and-test (ON)/(OFF)are required checks, but they come fromci.yml, whose top-levelpaths:filter excludessrc/bonsai/**. A workflow skipped by path filtering leaves its required checks in a "Pending" state forever, so Bonsai-only pull requests are permanently blocked (and show onlylint-formatting). Identical pattern on #9479, #9489, #9491, #9494.Change
paths:filter soci.ymlalways triggers.changesjob (dorny/paths-filter@v4) that reproduces the previous list of relevant paths.compile-and-testmatrix job withif: needs.changes.outputs.code == 'true'.Per GitHub's documented behavior, a job skipped by a conditional reports Success, whereas a workflow skipped by path filtering does not. So:
src/bonsai/**(or docs, etc.) changed ->compile-and-testis skipped and its required checks pass, unblocking the PR.Build reuse is unchanged: the existing
ccacheaction already reuses compiled objects across runs.Verification
This PR only touches
.github/workflows/ci.yml, which is in the filtered list, so the fullcompile-and-testrun is exercised here. The skip path will be exercised by a latersrc/bonsai/**-only PR.This PR is AI-generated.